From patchwork Tue Mar 15 17:53:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Dufresne via libcamera-devel X-Patchwork-Id: 15452 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B3B66BDE17 for ; Tue, 15 Mar 2022 17:53:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DC5CF632E3; Tue, 15 Mar 2022 18:53:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1647366834; bh=LlkPC7UxN/GbUl27IIRA34Nuo/2f58Xfhz4cQrcwbRU=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ChhMgqDUVo8s34tluwNvJhijimOQh4zLT31avJvTii7nbF3uPewUgr5UPSPGrbBQ5 2gisL9HM4QwtKoQ9yMtliR7p13SPnHm+/TKPMyPe2F96kNgvPzmcXtRamE9/zmL7iO o89jVZfC1OaFDTyRuMDsufgRoio35jD0CN90nBDE+W7k7Ympr8bZqViRNNYrl73VF5 8Ns4SQuMitXGbQ0lwuGGceYRX6AcdjI09g5e6IfWlOfROFCIMCS+IrYpnd3zWsyF7h awyxJrzpXrsWUNNSEA9dluDs7b1Wwub4IElyY0oLlKeKqH8wGWiizwqgq/QCXfF4b/ fF3j0U4Tuc4KA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 937B7604DA for ; Tue, 15 Mar 2022 18:53:53 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MFV/HUvH"; dkim-atps=neutral Received: from Monstersaurus.ksquared.org.uk.beta.tailscale.net (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 151401BBB; Tue, 15 Mar 2022 18:53:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1647366833; bh=LlkPC7UxN/GbUl27IIRA34Nuo/2f58Xfhz4cQrcwbRU=; h=From:To:Cc:Subject:Date:From; b=MFV/HUvHMZWNTbbTyXL7dBM4LNel0Yy6xdRO2zfERfS1CNQxSx4k+O/k87bAphKoL i+PqKNI1OZbQLL2lHA5waB9VQKcVn4QioMjVsX0auVjnniq1exrBjSMH6gRBKAQNge NFKQnxvSNcrVfz1GP38MMbMou+ldbUsMS+GlH0XY= To: libcamera devel Date: Tue, 15 Mar 2022 17:53:42 +0000 Message-Id: <20220315175345.479951-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/3] ipa: ipu3: af: Small improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Nicolas Dufresne via libcamera-devel Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Following review of the IPU3 Af implementation, the following additional improvements were identified. No functional change to the running of the algorithm is intended or expected, though this does remove a memcpy, and hopefully make it easier to use custom ROI's and return the AF regions in later developments. Kieran Bingham (3): ipa: ipu3: af: Move constants to implementation ipa: ipu3: af: Use geometry classes to perform grid centering ipa: ipu3: af: Remove redundant memcpy src/ipa/ipu3/algorithms/af.cpp | 109 +++++++++++++-------------------- src/ipa/ipu3/algorithms/af.h | 13 +--- 2 files changed, 43 insertions(+), 79 deletions(-)