From patchwork Thu Feb 24 15:11:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 15384 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A5819BE08A for ; Thu, 24 Feb 2022 15:11:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 00B9361154; Thu, 24 Feb 2022 16:11:21 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Yz7pBFE5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C0E38601F9 for ; Thu, 24 Feb 2022 16:11:18 +0100 (CET) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:ce74:6df2:4b76:b230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 682C1DD; Thu, 24 Feb 2022 16:11:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1645715478; bh=/SyoV1xT3wBJzNgMxrWgLhXwXIANCZ3lQXJ0eY8KNHc=; h=From:To:Cc:Subject:Date:From; b=Yz7pBFE5DmWEnMoyDm0fV+ulHG6L+p3XF7a/wLQb7cJtQjIGrPYsUGIrxqqn7lO0V 8R57owlVtpg7yyaD+BsuEvD0w67aksea2B/NJuUvfqjyzRW+CIIRvXP15TiYUvWa7R ijHo6JS3aOhzRYAh0H5ioX2kSkqRxVNFspD1o5VU= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Thu, 24 Feb 2022 16:11:09 +0100 Message-Id: <20220224151113.109858-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/4] ipa: ipu3: Misc clean up X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, While working on AGC porting from IPU3 to RkISP1, a few minor changes were proposed to clean the variables and function usage. Report those changes in IPU3. In v2: - Correct the filterExposure() calculation to use the same as RkISP1 - Rewrite some comments - Remove the caching of analogue gain and exposure In v3: - Remove all local references to lineDuration_ and use the context everywhere in IPAIPU3 In v4: - Remove lineDuration calculation in IPU3Agc::configure - Clean only frameContext at configure() - Add clamping of gain values in IPU3Awb Jean-Michel Hautbois (4): ipa: ipu3: Return filtered value ipa: ipu3: Shorten exposure and gain lines ipa: ipu3: agc: Introduce lineDuration in IPASessionConfiguration ipa: ipu3: awb: Clamp gain values src/ipa/ipu3/algorithms/agc.cpp | 100 +++++++++++++++++--------------- src/ipa/ipu3/algorithms/agc.h | 6 +- src/ipa/ipu3/algorithms/awb.cpp | 8 +++ src/ipa/ipu3/ipa_context.cpp | 8 +++ src/ipa/ipu3/ipa_context.h | 4 ++ src/ipa/ipu3/ipu3.cpp | 35 ++++++----- 6 files changed, 96 insertions(+), 65 deletions(-)