From patchwork Thu Feb 24 11:33:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 15376 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A5435BF415 for ; Thu, 24 Feb 2022 11:33:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7EE316115E; Thu, 24 Feb 2022 12:33:54 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SrN4mIhU"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E822D601F9 for ; Thu, 24 Feb 2022 12:33:52 +0100 (CET) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:ce74:6df2:4b76:b230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 807DBDD; Thu, 24 Feb 2022 12:33:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1645702432; bh=OTiqTWZwBz/30EYUkdDHHXIQj+tG+67Mkcu6A+ecnjc=; h=From:To:Cc:Subject:Date:From; b=SrN4mIhUM2IUip1qUSzQ4xYRWzzEDWJQrJbLZO1Xs2JWVilrvBPxzQgV9O9y4DB5c WelPcwLjmhclrwdiS1e7MdZTaiuhk8u3enZ+wOQdOhXMd2GTSD3ryiSlTrDiH6x8x8 eHLGMYGKqJkt/DJgn86FKTMVGivCdNoU/cI9FeD0= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Thu, 24 Feb 2022 12:33:42 +0100 Message-Id: <20220224113347.80001-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/5] IPA RkISP1 awb and misc improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This series introduces several algorithms or tuning parameters for the RkISP1 IPA. The first algorithm is the black level correction. The output is washed out if no black correction is applied. It uses the tuning values from the imx219 data file in RPi. Patch 3/5 introduced in v3 makes the Histogram class able to use const uint32_t arrays. Patch 4/5 introduces the histogram IQ mean estimation as for the IPU3 and uses the maximum of the relative luminance gain and the iqMean gain to determine the shutter speed and analogue gain to apply. Now, patch 5/5 can estimate the AWB gains to apply on the red and blue channels. The RkISP1 could theoretically give us the red, green and blue mean values for the current frame, but the kernel seems to lack support for this. Use the YCrCb estimation instead, and convert the values to RGB before estimating the gains. We don't have a grid of average values, only a global mean for each channel. I have removed two algorithms from this series: sensor degamma and crosstalk matrix. Those need a bit more work (sdg curve may be the wrong one according to the previous review, and the crosstalk matrix is not a tuned one). I have made some captures (qcam seems to invert width and height when saving the image though): [1]: agc only (current master): https://snipboard.io/dFO23J.jpg [2]: [1] with histogram and black level: https://snipboard.io/fd9zC2.jpg [3]: [2] with awb: https://snipboard.io/Sp9Ei6.jpg This is the state with this v2 series applied on top of master. And for the record, I picked the previous sdg and ctk algorithms to capture with those: [4]: [3] with sensor degamma: https://snipboard.io/5QO46g.jpg [5]: [4] with crosstalk matrix: https://snipboard.io/tDOV7l.jpg Jean-Michel Hautbois (5): ipa: rkisp1: Use frame counter for the request queued ipa: rkisp1: Introduce Black Level Correction ipa: libipa: Histogram: Constify the constructor span ipa: rkisp1: agc: Add a histogram-based gain ipa: rkisp1: Introduce AWB src/ipa/libipa/histogram.cpp | 2 +- src/ipa/libipa/histogram.h | 2 +- src/ipa/rkisp1/algorithms/agc.cpp | 94 ++++++++++++-- src/ipa/rkisp1/algorithms/agc.h | 6 +- src/ipa/rkisp1/algorithms/awb.cpp | 180 ++++++++++++++++++++++++++ src/ipa/rkisp1/algorithms/awb.h | 33 +++++ src/ipa/rkisp1/algorithms/blc.cpp | 57 ++++++++ src/ipa/rkisp1/algorithms/blc.h | 30 +++++ src/ipa/rkisp1/algorithms/meson.build | 2 + src/ipa/rkisp1/ipa_context.cpp | 40 +++++- src/ipa/rkisp1/ipa_context.h | 21 ++- src/ipa/rkisp1/rkisp1.cpp | 7 + 12 files changed, 454 insertions(+), 20 deletions(-) create mode 100644 src/ipa/rkisp1/algorithms/awb.cpp create mode 100644 src/ipa/rkisp1/algorithms/awb.h create mode 100644 src/ipa/rkisp1/algorithms/blc.cpp create mode 100644 src/ipa/rkisp1/algorithms/blc.h