From patchwork Tue Dec 28 21:59:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 15226 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D77A9BF415 for ; Tue, 28 Dec 2021 21:59:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CB96760912; Tue, 28 Dec 2021 22:59:58 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YQONsu8F"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6694B60868 for ; Tue, 28 Dec 2021 22:59:57 +0100 (CET) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D63393E7 for ; Tue, 28 Dec 2021 22:59:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1640728797; bh=aio5iUUGfeJV15XJGhkf3KUKPJzyATCigmSzFVstUWo=; h=From:To:Subject:Date:From; b=YQONsu8FEC3BMpR7bkfRu8psj/qzRq6wjHFNlvBb+Zd0aZbWS3HPBYLYd7Df8Jz5n ORxucqL5928Q4Ai0DE4xKwy9WG1GoR5Bg3GHDKPYJoqHOWGNuCxhc+vUnOFXU+bL7P 1BZ9s9U4JcbiAJG11ZfhmCehBsc292sNWndJCZVE= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 28 Dec 2021 23:59:46 +0200 Message-Id: <20211228215951.32396-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/6] libcamera: Improve debug messages in V4L2 compat layer X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This patch series improves the debug messages printed by the file operation handlers in the V4L2 compat layer. Before the series, the log messages printed the file descriptor of the V4L2 file as an integer: [207:37:26.959469077] [32330] DEBUG V4L2Compat v4l2_camera_proxy.cpp:531 Servicing vidioc_querybuf fd = 3 [207:37:26.959608478] [32330] DEBUG V4L2Compat v4l2_camera_proxy.cpp:549 Servicing vidioc_qbuf, index = 0 fd = 3 Now, the file path is printed as well, and the message is formated as a function call for better readability: [207:32:30.769491737] [32181] DEBUG V4L2Compat v4l2_camera_proxy.cpp:544 [/dev/video2 (fd:3)] vidioc_querybuf() [207:32:30.769565454] [32181] DEBUG V4L2Compat v4l2_camera_proxy.cpp:563 [/dev/video2 (fd:3)] vidioc_qbuf(index=0) Laurent Pinchart (5): v4l2: v4l2_compat_manager: Print path and fd in openat() v4l2: v4l2_camera_file: Store file description v4l2: v4l2_camera_proxy: Drop trace message from freeBuffers() v4l2: v4l2_compat_manager: Store V4L2CameraFile in mmaps_ v4l2: v4l2_camera_proxy: Use file description in debug messages src/v4l2/v4l2_camera_file.cpp | 28 +++++++++++- src/v4l2/v4l2_camera_file.h | 8 +++- src/v4l2/v4l2_camera_proxy.cpp | 76 ++++++++++++++++++++------------ src/v4l2/v4l2_camera_proxy.h | 7 +-- src/v4l2/v4l2_compat_manager.cpp | 18 ++++---- src/v4l2/v4l2_compat_manager.h | 2 +- 6 files changed, 95 insertions(+), 44 deletions(-) base-commit: 94a1afd0fc27216d6eca9506d8794c7a907f8121