From patchwork Tue Nov 30 11:22:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 14891 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1192CBDB13 for ; Tue, 30 Nov 2021 11:23:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5A76F605BA; Tue, 30 Nov 2021 12:23:17 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="FLLfXGbm"; dkim-atps=neutral Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B5616011A for ; Tue, 30 Nov 2021 12:23:15 +0100 (CET) Received: by mail-wm1-x32b.google.com with SMTP id p27-20020a05600c1d9b00b0033bf8532855so14500899wms.3 for ; Tue, 30 Nov 2021 03:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=We4AJcC8qdW9J7nm4W2rNGGqT/cvewB/Fz/Cb9Xsw7g=; b=FLLfXGbm0lT0RTlSeMJX2FNsSVMks2V3gEh9M5AJXg3SLxfu27tht1NMN0PREEufrB pUPlgEtPy3/K2twnL5akeaOkwSywJcVb1SicLJ7pPPjVGSFg688Z7+h2gsIdvWnqaiVl A6wgswdN6VRICZvK90M+2v5lKduu9K9+QGAa//XZrDWexSxrrON7GKY8eG8DcC/X0v4u 5Qnp7HLFCShtu+BP8QSZvWP58aVbfPpuclC+5CTB2qftCjvhGobFa+20GfYdUlf0cpzK 3xg5HnGmFnqGZ0vDOuP2xz9zTybQxbqIDSAGTM6AJpwBxoRRjAoTGth3jKf871qjGYVQ D3+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=We4AJcC8qdW9J7nm4W2rNGGqT/cvewB/Fz/Cb9Xsw7g=; b=5v9+8LeMd1JrJWeZJ8jCsTLQFHJAM+BgHvzq/NMiQVsWLuxVR9x6UgB0LsAYxEGZ8k QndUf5dYj43m13lmgiljXe+299LGYyS9/xSXYj1fq/zY4xDn12Po7QOsa2724MWrq8UV WsQcHIiU6Rjuz4A6zyulCSIDuuYf1zp4IWMdGLY+uiZQHw2PhLJ1CZzV4HguzuSpEk8P xmEsVIxSBKnkYqaQG8HFtA6eWdjTuHxWQEejGtTsfwvEaEt6JSspv6+Goru689oNr16l G3lD7NbwPmAt0LJGpioDyXYrPorgdeY8fIb9gHhbh8n9XpnCNxudN8pAtvQC6i7La+Vs 7RTg== X-Gm-Message-State: AOAM531QUJHl+O8LF6aDtdEs6P8AcY60C0nIDFOJ/xg67eUR7Xk7nd4Z M4S9xxefoIb0+w6JFI1iG5i3/oTV5dHZUFo2 X-Google-Smtp-Source: ABdhPJxc9FdFwFZ2c+1VN35BD/hM0kIzP8O4JGrugmKuILQAqFUmVYYQwTwJpktqTVGyC9bAzxIfYg== X-Received: by 2002:a05:600c:6016:: with SMTP id az22mr4252869wmb.11.1638271394524; Tue, 30 Nov 2021 03:23:14 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id u2sm19054923wrs.17.2021.11.30.03.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 03:23:14 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Nov 2021 11:22:57 +0000 Message-Id: <20211130112259.18723-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] Buffer format and allocation fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone A couple of smallish fixes to the Raspberry Pi pipeline handler's buffer format selection and allocation code: 1. The first commit fixes under-allocation of embedded data buffers when an application requests a raw stream and supplies buffers for it. (Fix actually sent to me by Naush!) 2. The second commit uses the raw stream's bit depth and packing (when requested by the application) to determine what we select from the sensor. We should really have been doing this all along. Thanks! David David Plowman (2): pipeline: raspberrypi: Fix under-allocation of embedded data buffers pipeline: raspberrypi: Choose bit depth and packing according to raw stream .../pipeline/raspberrypi/raspberrypi.cpp | 58 +++++++++++-------- 1 file changed, 34 insertions(+), 24 deletions(-)