From patchwork Tue Nov 23 09:14:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 14684 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A78C5BDB13 for ; Tue, 23 Nov 2021 09:15:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 39A7C60376; Tue, 23 Nov 2021 10:14:59 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uKj2mi8K"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 137AB60121 for ; Tue, 23 Nov 2021 10:14:57 +0100 (CET) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:3c3b:9149:b:8aa9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9BA29A1B; Tue, 23 Nov 2021 10:14:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637658896; bh=p4iBPmacD3VX3QdKcxeLGR1CszcEFTrNyx6o26JMGQo=; h=From:To:Cc:Subject:Date:From; b=uKj2mi8K577qWtXUyeLyXrOkOlq+clK+fifvIQk1vQgoJai3AzEU5v15jP6xeuvEi 9ttVIKCW3Pgn6+u/byBJI1RDiKEYCX3LeFJivo41jTOcazTTy2eRLhRWwWMqattAbv ja0SXq5tCpcoF/l8YHUxcc+bXhZJ2AS2DYU1sASw= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 23 Nov 2021 10:14:40 +0100 Message-Id: <20211123091451.67404-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 00/11] Introduce AGC for RkISP1 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This is the v2 of the RkISP1 AGC series. In this version, a template for the Algorithm class is introduced in patch 6/11 and 7/11 for the doc missing. Now that AGC is working pretty nicely on IPU3, make it work on RkISP1 too. For that purpose, patches 1/11 to 5/11 reuse the concepts of Algorithm and IPAContext and make those part of the rkisp1 IPA. The effective sensor controls can then be reported with patch 8/11. Patch 9/11 is a small adaptation of the IPU3 AGC: we reuse the relative luminance estimation, basing it on the Y mean measured by the ISP, and removes the histogram based calculation for now. In v2 the improvements from Laurent's series "ipa: ipu3: agc: Misc improvements" are also included. Patch 10/11 introduces a new prepare() call from the Algorithm class in AGC, and patch 11/11 is making it revision independant. Jean-Michel Hautbois (11): libipa: Correct IMX219 in CameraSensorHelper ipa: rkisp1: Pass IPASettings at init call ipa: Do not modify the sensor limits ipa: rkisp1: Instantiate CameraSensorHelper ipa: rkisp1: Introduce IPAContext ipa: libipa: Introduce Algorithm class template ipa: ipu3: Document AWB Algorithm overriden functions ipa: rkisp1: Report and use sensor controls ipa: rkisp1: Introduce AGC ipa: rkisp1: agc: Introduce prepare call ipa: rkisp1: agc: Configure the number of cells used by HW include/libcamera/ipa/rkisp1.mojom | 6 +- src/ipa/ipu3/algorithms/algorithm.h | 12 +- src/ipa/ipu3/algorithms/awb.cpp | 9 + src/ipa/ipu3/algorithms/meson.build | 1 - src/ipa/ipu3/ipu3.cpp | 4 +- .../{ipu3/algorithms => libipa}/algorithm.cpp | 35 +-- src/ipa/libipa/algorithm.h | 41 +++ src/ipa/libipa/camera_sensor_helper.cpp | 2 +- src/ipa/libipa/meson.build | 1 + src/ipa/rkisp1/algorithms/agc.cpp | 286 ++++++++++++++++++ src/ipa/rkisp1/algorithms/agc.h | 58 ++++ src/ipa/rkisp1/algorithms/algorithm.h | 28 ++ src/ipa/rkisp1/algorithms/meson.build | 5 + src/ipa/rkisp1/ipa_context.cpp | 110 +++++++ src/ipa/rkisp1/ipa_context.h | 51 ++++ src/ipa/rkisp1/meson.build | 11 +- src/ipa/rkisp1/rkisp1.cpp | 128 ++++---- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +- 18 files changed, 701 insertions(+), 92 deletions(-) rename src/ipa/{ipu3/algorithms => libipa}/algorithm.cpp (74%) create mode 100644 src/ipa/libipa/algorithm.h create mode 100644 src/ipa/rkisp1/algorithms/agc.cpp create mode 100644 src/ipa/rkisp1/algorithms/agc.h create mode 100644 src/ipa/rkisp1/algorithms/algorithm.h create mode 100644 src/ipa/rkisp1/algorithms/meson.build create mode 100644 src/ipa/rkisp1/ipa_context.cpp create mode 100644 src/ipa/rkisp1/ipa_context.h