From patchwork Fri Nov 19 11:16:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 14649 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1FCADBF415 for ; Fri, 19 Nov 2021 11:17:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DB5F960376; Fri, 19 Nov 2021 12:17:01 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VL1XIrpa"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 868F4600B5 for ; Fri, 19 Nov 2021 12:16:59 +0100 (CET) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:db30:8e54:a96:9838]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 214961974; Fri, 19 Nov 2021 12:16:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637320619; bh=odUArVZcYEb/2jodosjT0R5w50aIRqAXZlxXYlFw2hc=; h=From:To:Cc:Subject:Date:From; b=VL1XIrpa/Ddwru4H0YY/luKZV4huJXKcqN33XIQ/0BiseAC/UuKqoWzHGE1UxOuRr hQrfi/X3YOCTLRhr01BcNV+cFXP3/F0BfW8jia0+Fawv9m7cwqjnCO3cBGjFsfSPui EhO8BzqBMxwhZY2r0MtRWNv1brPAdbDAwnY8XaOs= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Fri, 19 Nov 2021 12:16:46 +0100 Message-Id: <20211119111654.68445-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/8] Introduce AGC for RkISP1 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, Now that AGC is working pretty nicely on IPU3, make it work on RkISP1 too. For that purpose, patches 1/8 to 5/8 reuse the concepts of Algorithm and IPAContext and make those part of th rkisp1 IPA. The effective sensor controls can then be reported. Patch 6/8 is a small adaptation of the IPU3 AGC: we reuse the relative luminance estimation, basing it on the Y mean measured by the ISP, and removes the histogram based calculation for now. Patch 7/8 introduces a new prepare() call from the Algorithm class in AGC, and patch 8/8 is making it revision independant. Jean-Michel Hautbois (8): ipa: rkisp1: Pass IPASettings at init call ipa: rkisp1: Instantiate CameraSensorHelper ipa: rkisp1: Introduce IPAContext ipa: ipu3: Introduce the Algorithm class ipa: rkisp1: Report and use sensor controls ipa: rkisp1: Introduce AGC ipa: rkisp1: agc: Introduce prepare call ipa: rkisp1: agc: Configure the number of cells used by HW include/libcamera/ipa/rkisp1.mojom | 6 +- src/ipa/ipu3/ipa_context.cpp | 3 + src/ipa/rkisp1/algorithms/agc.cpp | 258 +++++++++++++++++++++++ src/ipa/rkisp1/algorithms/agc.h | 58 +++++ src/ipa/rkisp1/algorithms/algorithm.cpp | 101 +++++++++ src/ipa/rkisp1/algorithms/algorithm.h | 32 +++ src/ipa/rkisp1/algorithms/meson.build | 6 + src/ipa/rkisp1/ipa_context.cpp | 102 +++++++++ src/ipa/rkisp1/ipa_context.h | 52 +++++ src/ipa/rkisp1/meson.build | 10 +- src/ipa/rkisp1/rkisp1.cpp | 120 ++++++----- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 12 +- 12 files changed, 703 insertions(+), 57 deletions(-) create mode 100644 src/ipa/rkisp1/algorithms/agc.cpp create mode 100644 src/ipa/rkisp1/algorithms/agc.h create mode 100644 src/ipa/rkisp1/algorithms/algorithm.cpp create mode 100644 src/ipa/rkisp1/algorithms/algorithm.h create mode 100644 src/ipa/rkisp1/algorithms/meson.build create mode 100644 src/ipa/rkisp1/ipa_context.cpp create mode 100644 src/ipa/rkisp1/ipa_context.h base-commit: ff89aa0185bfd141c72ed44bd2e5224df1465a3a