From patchwork Fri Nov 19 10:25:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 14643 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3975EBDB13 for ; Fri, 19 Nov 2021 10:26:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 387B46038C; Fri, 19 Nov 2021 11:26:12 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UxbzymcG"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 299946022F for ; Fri, 19 Nov 2021 11:26:10 +0100 (CET) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:db30:8e54:a96:9838]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AF2CD1959; Fri, 19 Nov 2021 11:26:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637317569; bh=Q4e1h0BOZ+QojwkT6J4tOyL7jca61Rg4CRxp4RdXQc8=; h=From:To:Cc:Subject:Date:From; b=UxbzymcGPIWfbUJ/tnuXOo6cd0Ox2Qu3+tDq8YWUX6tSopNahS+VX8QClM4P1XdPC EXWyZZCkXG97tSjsY8rPEggsDtKU1MZIzgzHHPM1rf1roIpSxmhWlCYLNeWFFt7Xbt zBRiyu/DsGr/PQVciFY1JedyCqqYu6a2+cFO2P2o= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Fri, 19 Nov 2021 11:25:57 +0100 Message-Id: <20211119102559.56522-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] libipa: Fix doc and imx219 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, While developping on RkISP1 I was using the imx219 module and discovered that CameraSensorHelper is not correct for this one (patch 2/2). After having fixed it, I noticed I could get a gainCode of 0, which obviously is wrong (I expected it to be 1). Patch 1/2 aims to fix it. Jean-Michel Hautbois (2): libipa: Round gain code before returning the value libipa: Correct IMX219 in CameraSensorHelper src/ipa/libipa/camera_sensor_helper.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)