From patchwork Thu Nov 4 06:42:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 14451 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B25F4BDB1C for ; Thu, 4 Nov 2021 06:43:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E51B3600BF; Thu, 4 Nov 2021 07:43:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="GfRRPQz/"; dkim-atps=neutral Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AFAA9600B8 for ; Thu, 4 Nov 2021 07:42:59 +0100 (CET) Received: by mail-pl1-x62a.google.com with SMTP id u17so5625796plg.9 for ; Wed, 03 Nov 2021 23:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=M5nQkO0DTW9phtqukORl2rn2OcC01aWVwMeB9lO0IS0=; b=GfRRPQz/ACDNp2hf5Bn//6yhp3cF0HxWqc5yPTyLIcXyO/lelNpGsrPzCm5s6dGpBk qSoaRSvTAWpWUZqimQ2OFGRx2BM59ItOaf75+jcuXeR6LtWwcTlVIn8R1GRDAP3Mdqk6 LGHhb41cNE8/1PfQUurwxVFO3tsp4bL7P1dvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=M5nQkO0DTW9phtqukORl2rn2OcC01aWVwMeB9lO0IS0=; b=KMAG8asCOGoWEHU9OP5urWflJXj4E+NHwfF6SrtjvSwi2NpYtaVgLlOA4+FRlHtfJj TbPnH5Px2IGIFoAAtXzyAOza8kQDiOfS3cR82YUsyX8M0KhCLKxTHo5KZqA5oMdeZXwn 7LrrPBPN2v9RD45AVahuLvS6kI0hn42K/7f3P6QMeoXLKRD6NtrGrEtBTqoQOQ5WhuY7 JV0miHALxdqdYSahxbvpOXh4C1WIoiQkb/NkY+cjjcHaY0Cn2hnqd+xxFbXGYV1Z8dqG YevPDAZvdex/XDSoZcPLqDb8095XbTdi4Ast2HcY8jOk12WlUXwaP/3Ofr4UF9XtKMe/ Cg3Q== X-Gm-Message-State: AOAM5321y4bYxjbNmcX+kYLTLGNIY3haBu/Me1Mi270UtvJ2X3l56XTb aA92O0n6C8P7gG3WtbrQAd5I5JmhdbjPCw== X-Google-Smtp-Source: ABdhPJxCthE/IAtMgsWpoc/nBwZsLzXtcjvDmRBYlzwRkeqSczVXA6Ks5fkllAJcBSuZsDhyC/C9aQ== X-Received: by 2002:a17:90a:d515:: with SMTP id t21mr20238462pju.123.1636008177719; Wed, 03 Nov 2021 23:42:57 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:203:9022:fd2e:f66e:b99b]) by smtp.gmail.com with ESMTPSA id s6sm4265580pfu.137.2021.11.03.23.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 23:42:57 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Thu, 4 Nov 2021 15:42:49 +0900 Message-Id: <20211104064252.2091330-1-hiroh@chromium.org> X-Mailer: git-send-email 2.33.1.1089.g2158813163f-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/3] Apply a sensor test pattern mode X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This enables CameraSensor to apply a sensor test pattern mode specified by Request and then actually applies it in IPU3 pipeline handler. Change in v4: - Address comments from Jacopo and Kieran - Change the type of test pattern mode values to its Enum from int32_t - Add TestPatternModeUnset - Move the code of filtering and apply test pattern mode to CameraSensor so that we don't have to duplicate code in each pipeline handler Hirokazu Honda (3): camera_sensor: Deal test pattern mode control values with its enum libcamera: camera_sensor: Enable to set a test pattern mode libcamera: pipeline: ipu3: Apply the requested test pattern mode include/libcamera/internal/camera_sensor.h | 18 +++- .../internal/camera_sensor_properties.h | 3 +- src/libcamera/camera_sensor.cpp | 99 +++++++++++++++++-- src/libcamera/control_ids.yaml | 5 + src/libcamera/pipeline/ipu3/ipu3.cpp | 35 ++++++- 5 files changed, 141 insertions(+), 19 deletions(-) --- 2.33.1.1089.g2158813163f-goog