From patchwork Tue Oct 26 11:23:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 14333 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0C58CBF415 for ; Tue, 26 Oct 2021 11:23:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 47E9C64885; Tue, 26 Oct 2021 13:23:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aF8Iu5Ej"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 87A0760123 for ; Tue, 26 Oct 2021 13:23:44 +0200 (CEST) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2317B3F0; Tue, 26 Oct 2021 13:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1635247424; bh=BZ2FW+4G847ekHnSeq4iLgKI+DWkZg0CWB4hJLxhBJQ=; h=From:To:Cc:Subject:Date:From; b=aF8Iu5EjwDSEUkqHOzjKYgYTI37xHSFBTJ0Pv3wSHq8ykJISIIMCuazQNXph8akOQ xxcfXLHb3TG0LGxV+oodxRwHGVHxXxfepzsaJ6c0SdhrtYs+kz6DJ+nZhKG1fYs7Qy +iBN9vvozyJHskix8MWx/AAHyz+GV5LXkk9+bzuo= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 26 Oct 2021 13:23:21 +0200 Message-Id: <20211026112340.110169-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 00/19] Document IPU3 IPA X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone ! We have modified most of the AWB and AGC algorithms now, we have better structure names and handling, it is time to make all the documentation follow the same path. It includes patches from both Kieran and me. This series merges multiple patches/series already sent to ease the follow-up. We have four parts: - Add documentation for the IPA IPU3 class - Improve IPU3 algorithms documentation -> those two parts were mostly in "[PATCH 00/11] Document all the IPU3 IPA classes" - Make it compile with Doxygen (this is new) - Add a design document for IPU3 IPA -> this has been sent before as "[RFC PATCH] Documentation: IPU3 IPA Design guide" As there was a mismatch, the branch used in v2 did not include Laurent's comments (sorry :-/) so those should now be taken into account. v5: - small comments - added the remaining R-b after v4 v4: - re-authored some patches to Kieran - comments adressed Enjoy :-) ! Jean-Michel Hautbois (12): ipa: ipu3: Document IPAIPU3 class interface ipa: ipu3: Document IPAIPU3::configure ipa: ipu3: Document the IPAIPU3 class ipa: ipu3: Explicitly use the statistics parameter ipa: ipu3: awb: Add AWB class documentation ipa: ipu3: awb: Reword accumulator documentation ipa: ipu3: agc: Document AGC mean-based algorithm ipa: ipu3: tonemapping: Generate the LUT only on gamma change ipa: ipu3: tonemapping: Implement configure call ipa: ipu3: tonemapping: Add the documentation for ToneMapping ipa: ipu3: Fix badly documented context variables ipa: ipu3: Implement an empty stop() function Kieran Bingham (7): Documentation: IPU3 IPA Design guide ipa: ipu3: ipa_context: Fix file reference ipa: ipu3: Fix the IPU3 AWB doxygen references ipa: ipu3: algorithms: awb: Privatize internal structures ipa: ipu3: Isolate ipa_context documentation Documentation: Include IPU3 in Doxygen build ipa: ipu3: ipa_context: Fix doxygen warnings Documentation/Doxyfile.in | 1 + Documentation/meson.build | 1 + src/ipa/ipu3/algorithms/agc.cpp | 80 +++++- src/ipa/ipu3/algorithms/agc.h | 6 +- src/ipa/ipu3/algorithms/awb.cpp | 120 +++++---- src/ipa/ipu3/algorithms/awb.h | 1 + src/ipa/ipu3/algorithms/tone_mapping.cpp | 51 +++- src/ipa/ipu3/algorithms/tone_mapping.h | 1 + src/ipa/ipu3/ipa_context.cpp | 136 +++++++++++ src/ipa/ipu3/ipa_context.h | 3 +- src/ipa/ipu3/ipu3-ipa-design-guide.rst | 155 ++++++++++++ src/ipa/ipu3/ipu3.cpp | 298 +++++++++++++---------- src/ipa/ipu3/meson.build | 1 + 13 files changed, 664 insertions(+), 190 deletions(-) create mode 100644 src/ipa/ipu3/ipa_context.cpp create mode 100644 src/ipa/ipu3/ipu3-ipa-design-guide.rst