From patchwork Fri Oct 22 14:39:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 14259 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CE3C9BDB1C for ; Fri, 22 Oct 2021 14:40:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 05E9868F5A; Fri, 22 Oct 2021 16:40:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="rbh0vvB4"; dkim-atps=neutral Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F262D6012A for ; Fri, 22 Oct 2021 16:40:12 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id a20-20020a1c7f14000000b003231d13ee3cso3632240wmd.3 for ; Fri, 22 Oct 2021 07:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Hm5qNXj+5LlZUAxAuDdQ7kiFTUyDrdHhNFL9lcDVCMo=; b=rbh0vvB4lcSLAcI7eeVSe+gO+7proVMHt4R0cxMpfDi8nlVBaeCcHvM1wG7OXyeHAw PCsFzKsqHZVH2z8+XdO3PwCKeXDpiBeNyBH+w/vdOsVvC08EjwfWZw5iqp+TRZPdzRlr Ly+5pcMue624YdzfuUdaRG5VMSL8gjp8sykk9kZpw5reUbVmf1rnUCu647EOJGc29SC3 FkNVVi2ahoH0Gl8QwIv/SRQ3T1S5wfVs/qw2G6XmWQs8psuRS6ElxtHldkpmrKfMivkI atfdsirsJ+kUBS6sjdZkA5OLS6Zc0gzaEsw4mUAgjbSs6XjTIELpLAeqQy8qafh4U1SF BpHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Hm5qNXj+5LlZUAxAuDdQ7kiFTUyDrdHhNFL9lcDVCMo=; b=PXE8Zx+NfIH/xF/OvagR2Sl0/frzD5gzFD+/z8+uVBjM0TLGHJrjLxzyv1bOiRGdSm tJ5qxhIweO7FbmuBLROdpUyIEvLSTFjFPHpxPMW4dFuaV9+zT0m9j/Hfh+f/qbyhVsYI zjypLbOXDMxFmbH2GPbzIL704ixXt+mbJIpX+uWUfzRX6m3LOMnb/IjkMsh6QRCdhK1E XH/m6hS4MEjAvZuRkKqnWe6dbh7YC13rFot5CSBiyBbIx5AlfGVCrYlRyCOBxGqg9TlF 1UHRwHp80FUgrxoCO2g1tzaEgs/vAVNsR3menCUem6ZTslZeJmzx4EHrfuW2LQ+269HA 9OVA== X-Gm-Message-State: AOAM533NJ0SAh60PbQOdImzmZ5axxk3D22hMG6HMBXlxvroeuAwmNqpo oDzgtqHocAgr093ZGo+O6rh1Uo8B8c/sD8CX X-Google-Smtp-Source: ABdhPJz5GTzW7JBZ19LIkMkLTgze4PMF4PLlPR56QYw+cRD+SLc0j4bMxPKjOSfuDHRQtUKH5bzung== X-Received: by 2002:a1c:c908:: with SMTP id f8mr29179408wmb.142.1634913612373; Fri, 22 Oct 2021 07:40:12 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:f00d:ddf0:61b0:a4cd]) by smtp.gmail.com with ESMTPSA id r205sm8577878wma.3.2021.10.22.07.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 07:40:11 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 22 Oct 2021 15:39:01 +0100 Message-Id: <20211022143907.3089419-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/6] Raspberry Pi: Conversion to media controller X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Very quick turn-around for v2 this time :-) I wanted to post this as it incorporates David's suggestions before others have started reviewing it as they do simplify things a bit. Differences from v1: - 1/6: Removes the BayerFormat::toMbusCode() as it is not needed. - 2/6: Return V4L2SubdeviceFormat from findBestMode to simplify the code a bit. This also makes the old 3/6 patch redundant. - 3/6: This is a new patch that sets the packing modes on the format correctly. Regards, Naush Naushir Patuck (6): libcamera: bayer_format: Add a toPixelFormat() helpers to the BayerFormat class pipeline: raspberrypi: Convert the pipeline handler to use media controller pipeline: raspberrypi: Set packing formats for the Unicam image node pipeline: raspberrypi: Remove "unpacked" format penalty in mode selection pipeline: raspberrypi: Account for a missing Unicam embedded data node pipeline: raspberrypi: Apply sensor flips at the start of configure() include/libcamera/internal/bayer_format.h | 3 + src/libcamera/bayer_format.cpp | 13 ++ .../pipeline/raspberrypi/raspberrypi.cpp | 214 ++++++++++-------- 3 files changed, 138 insertions(+), 92 deletions(-)