From patchwork Mon Oct 18 13:29:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 14161 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 92B4DC323E for ; Mon, 18 Oct 2021 13:29:32 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1128668F59; Mon, 18 Oct 2021 15:29:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GwxBCSlr"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 46AE168F56 for ; Mon, 18 Oct 2021 15:29:30 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.238.109.14]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E5E98C6; Mon, 18 Oct 2021 15:29:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1634563769; bh=8dz23fQ3lpXD0UzQoz057gzYYQ78ujuB6KRR03dr1Uo=; h=From:To:Cc:Subject:Date:From; b=GwxBCSlrbDKl25wJpc2KmZaJoJLVPOj31MpuirOqZeTpSed6je5P/hldN4saqAPim tPy1Z0yvPaihSK6/k6mYaNpJWDgIYK0sIfxDRLeQvWTiwvTySgCN10X/MW/2ZjD2QK zFSlNxlDkJtVnFloqLoYAuQUaVR5EBgzApG8bqNI= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Mon, 18 Oct 2021 18:59:12 +0530 Message-Id: <20211018132923.476242-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 00/11] android: Overhaul request handling X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This series has been a by-product of ongoing post-processing async work. The series attempts to de-couple how structures / information are stored to address and complete a request incoming to out HAL. The de-couple will help us to streamline and group information which can be consumed by the HAL layer easily. Emphasis on construction of HAL framework's structures (like capture results, camera3_stream_buffer_t) in-place, to complete the requests is done as part of the series. This de-couple will help the post-processor async work going forwards. The series is CTS-verified on top of master: 2f75a7e5b8c "libcamera: v4l2_subdevice: Set format field to V4L2_FIELD_NONE" PASS Results : 230/231 Failure - [110/231] android.hardware.camera2.cts.CameraDeviceTest#testPrepare fail: junit.framework.AssertionFailedError: Wait for a capture result timed out in 3000ms Laurent Pinchart (8): android: camera_request: Turn struct into a class android: camera_device: Build capture_result dynamically android: camera_stream: Pass StreamBuffer to process() android: camera_stream: Return non-const pointer from camera3Stream() android: camera_device: Use abortRequest() instead of open-coding it android: camera_request: Don't embed full camera3_stream_buffer_t android: camera_stream: Don't close fence if wait times out android: camera_stream: Define explicit move constructor and destructors Umang Jain (3): camera_device: Remove private scope of Camera3RequestDescriptor android: camera_stream: Plumb process() with Camera3RequestDescriptor android: camera_device: Create struct to track per stream buffer src/android/camera_device.cpp | 194 +++++++++-------------- src/android/camera_device.h | 27 +--- src/android/camera_request.cpp | 53 +++++++ src/android/camera_request.h | 62 ++++++++ src/android/camera_stream.cpp | 29 ++-- src/android/camera_stream.h | 12 +- src/android/jpeg/post_processor_jpeg.cpp | 6 +- src/android/jpeg/post_processor_jpeg.h | 3 +- src/android/meson.build | 1 + src/android/post_processor.h | 5 +- src/android/yuv/post_processor_yuv.cpp | 3 +- src/android/yuv/post_processor_yuv.h | 3 +- 12 files changed, 229 insertions(+), 169 deletions(-) create mode 100644 src/android/camera_request.cpp create mode 100644 src/android/camera_request.h