From patchwork Mon Oct 11 15:11:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 14084 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BF9D6C323E for ; Mon, 11 Oct 2021 15:11:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 342F568F4D; Mon, 11 Oct 2021 17:11:12 +0200 (CEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 20BAD6012B for ; Mon, 11 Oct 2021 17:11:10 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id AF8FEE0003; Mon, 11 Oct 2021 15:11:09 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 11 Oct 2021 17:11:38 +0200 Message-Id: <20211011151154.72856-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 00/16] IPU3 control info update and HAL frame durations X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As the patch subject suggests, this series is composed of two main parts, which concur in correctly handling the frame durations reported to the Android HAL. The series starts by allowing the IPU3 pipeline handler to select the optimal sensor size to feed the ImgU with. Umang's series is a requirement for this patch, otherwise the ImgU configuration fails. Patches 2 and 3 update the Camera's ControlInfoMap in response to a Camera::configure() call, by updating the controls limits in the ph and the IPA. From patch 4 on the Android HAL parts begins by collecting per-stream frame durations. As the frame durations are updated as part of the Camera's ControlInfoMap limits update it is necessary to configure the camera during the HAL startup. A few cleanup patches follows, including the correct handling of STALL durations Patch 10 introduces a filtering criteria for YUV streams: only streams that can produce 30 FPS can be registered for preview. I was not able to find this clearly specified in documentation but the requirement has been confirmed by the cros camera team and in the Intel HAL implementation. After two more cleanup patches the way ANDROID_CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES gets populated is changed to comply with the documentation. Note that this does not align with the Intel HAL implementation which registers 8 values instead of 4. v3 limits the reported FSP rage to 30 FPS and filters out preview resolutions not capable of sustaining such frame rate. The requirement comes from CTS RecordingTests and it is probably defined by the camcoder profile. v2->v3: - Limit the reported FPS range in the HAL only - Record the reson for filtering < 30 FPS preview resolutions - Address review comments and collect tags v1->v2: - add a patch to centralize the ImgU sizes definition - small grammar/spelling fixes here and there - Collect the actual minFPS when populating AE_AVAILABLE_FPS_RANGE instead of limiting it to 15, as suggested by Paul. Thanks j Jacopo Mondi (16): libcamera: ipu3: Use the optimal sensor size libcamera: ipu3: Centralize ImgU sizes definition libcamera: ipu3: Rationalize constant expressions names libcamera: ipu3: Split controls init/update ipa: ipu3: Update camera controls in configure() android: capabilities: Collect per-stream frame durations android: capabilities: Initialize camera state when building properties android: capabilties: Assume controls::FrameDurationLimits is supported android: capabilities: Use per-configuration durations android: capabilties: Correctly populate STALL durations android: capabilities: Collect absolute max frame durations android: Filter preview streams on FPS android: capabilities: Print output stream list android: Populate streams and duration in the same loop android: capabilties: Fix ANDROID_CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES android: capabilities: Cap frame rate to 30 FPS include/libcamera/ipa/ipu3.mojom | 3 +- src/android/camera_capabilities.cpp | 238 ++++++++++++++++++--------- src/android/camera_capabilities.h | 3 + src/ipa/ipu3/ipu3.cpp | 82 ++++++--- src/libcamera/pipeline/ipu3/cio2.cpp | 6 +- src/libcamera/pipeline/ipu3/cio2.h | 2 +- src/libcamera/pipeline/ipu3/imgu.cpp | 86 ++++------ src/libcamera/pipeline/ipu3/imgu.h | 23 +++ src/libcamera/pipeline/ipu3/ipu3.cpp | 148 ++++++++++------- 9 files changed, 372 insertions(+), 219 deletions(-) --- 2.33.0