From patchwork Tue Oct 5 08:56:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 14051 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 119D6C3243 for ; Tue, 5 Oct 2021 08:57:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 80EFE691B9; Tue, 5 Oct 2021 10:57:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="nWHNq0Xt"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 93A32684C6 for ; Tue, 5 Oct 2021 10:57:04 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id r10so19532413wra.12 for ; Tue, 05 Oct 2021 01:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bY0BqWgQAkaIOJ9S7x00Ai3OO24IIBpWAGHXdMO9IjY=; b=nWHNq0XtwVkrP7L6CVaz56+f9k0cCVv4MIOPwd8LSDEifD+D6BhPWiJez1UlmR1gGj ZM/BOVskuWIo22PKy+p8G48lkZo/zfCLaKPaosoyl/69dn3Pwax+J5/EZReDDA39gHEu nflpbFUSpYu/0PkJogbKqjSWnul3GeWA2G6tArQwV+UDC8QLZXEmtOArn7I4FknULDR/ 4U0FXKSH4pPrKfC403g80ID6ceNZlhM8yJODiIyM0sT/9B52+rMrGk+/uMYYXGeHVUhG caGeYv1cZ1PRskIofa9nHjov6ycDSwVE8AmueMGm3z+f34FKaES9edJuhM3TeUq+Nee6 ctrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bY0BqWgQAkaIOJ9S7x00Ai3OO24IIBpWAGHXdMO9IjY=; b=lGTyyqke3SLJVTJt+4bRvxmyP7MJ1La0QIaFAFXyIqShP2SV0EwZEswk1XmHTcv446 WynYWr5LX9gylcG2ynjF0LFrK0n4voyzftadTdLUCFmYtCE/h9u+3kYemL3Q21r1IVuS /T0ElIOU8EFK1vvzke+R0k3fg/eQ9g4wWJ5lHwdA49yte63FM53S90E3UTE/b6zDm8Zj QxojY5wlm1ioBa7dNjwnejkbqtLyvMDfBlR/H4tIsr2s/I8zWxC3bVX6QE/urXIAxeJw VQ+C8MvdlKwDyatAJOGhGvQCF3+eNsVz0tBo+PWkTIZgA71+FbKp1EidKBFTZjKEYbt+ +3mw== X-Gm-Message-State: AOAM531ewPtgIC9XPdqyPXKSYF86pUYgI4LTMJBxt1rpvQYI0g6uxyXE /KAJit1FxGYU/WYC7qS7IeHRdmrVceyNRlfR X-Google-Smtp-Source: ABdhPJzsU++gQKrIs6mj8EvmZaqf1m1KnuQnrHxVAZOZXdE6NOtHtHxW22qgBekyYUKaywD4amZYXg== X-Received: by 2002:adf:cd02:: with SMTP id w2mr7461525wrm.358.1633424224053; Tue, 05 Oct 2021 01:57:04 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:1ce1:9965:4328:89c4]) by smtp.gmail.com with ESMTPSA id h18sm16508666wrs.75.2021.10.05.01.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 01:57:03 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Tue, 5 Oct 2021 09:56:59 +0100 Message-Id: <20211005085700.16708-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/1] Raspberry Pi: Create empty control lists correctly X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Laurent, everyone Here's the v2 of this that I had promised, which patches another identical problem that occurs only when you stop and restart the camera (actually passing a ControlList back from the IPA). I took your suggestion, Laurent, as it was closer to the original, and also your "reviewed-by" tag in spite of the extra change, but obviously please still comment if necessary! As regards the ControlLists, it would be nice if the non-isolated "thread" version of the IPAProxy could complain in the same circumstances as the IPC version. Not sure what the best way is to ensure that, calling the serializer "just for fun" sounds a bit like overkill. Maybe only for start/configure methods that don't run repeatedly? Or only in debug builds? Or something else more cunning? Perhaps a question for another time... Thanks! David David Plowman (1): pipeline: raspberrypi: Create empty control lists correctly src/ipa/raspberrypi/raspberrypi.cpp | 13 +++++++++---- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++- 2 files changed, 11 insertions(+), 5 deletions(-)