From patchwork Thu Sep 23 08:37:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13904 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 85A7EBF01C for ; Thu, 23 Sep 2021 08:37:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CC25E6918C; Thu, 23 Sep 2021 10:37:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OBwLAX89"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D4D6687DC for ; Thu, 23 Sep 2021 10:37:57 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [IPv6:2405:204:8203:58de:7651:79c1:5e62:dca9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A04645E; Thu, 23 Sep 2021 10:37:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632386277; bh=WC5Y8m4j0lhSJgJHK8DYRoYAun3VMHKz8EbUPA9hJG4=; h=From:To:Cc:Subject:Date:From; b=OBwLAX898Y0nLwPIzhoTTZymSVv33ITgtnIW3H8acsAdR7xNsKwPxL/gv6+CASf9J HtXD9OHGX1Ex+uXyNrQEb8Y5LIIxeOUYV3cS9m++xgsuO3Yk7jqWuhqZ8eRvnOF1oW qVUyMngGb6xkRdRvM11DpXfzPoCXZ6nPhuQA/rus= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Thu, 23 Sep 2021 14:07:46 +0530 Message-Id: <20210923083748.146265-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/2] android: Fix generation of thumbnail for EXIF data X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Patch 1 provides a clarification about CameraMetadata hint initialization value for number of entries. CameraMetadata can resize on the fly (if required), so the constructor values are more of less of a hint, deliberately kept slightly bigger to avoid frequent resizes. Patch 2 fixes the thumbnail generation. Changes in v4: - Carry tags - Fix rebase fiasco in 2/2 Changes in v3: - Provide CameraMetadata hint value clarification - Be more defensive about not adding Size(0,0) for thumbnail by introducing a loop over values (As suggested by Jacopo in v2) Changes in v2: - Add an ASSERT to check entry size >= 4 Umang Jain (2): android: camera_capabilities: Clarify CameraMetadata allocation android: Fix generation of thumbnail for EXIF data src/android/camera_capabilities.cpp | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-)