From patchwork Tue Sep 14 16:37:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 13849 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4CF55BDC71 for ; Tue, 14 Sep 2021 16:37:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7DBC56918B; Tue, 14 Sep 2021 18:37:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="u2lljLsB"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 832F660132 for ; Tue, 14 Sep 2021 18:37:13 +0200 (CEST) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:d0a7:2575:a724:b30a]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 17A5F2A5; Tue, 14 Sep 2021 18:37:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1631637433; bh=PKkc5tbouGBKawHkruyD2ow82Lt93FAA79z4yv2k7R0=; h=From:To:Cc:Subject:Date:From; b=u2lljLsBoku8dUvBCwiw4270opp413askQKDKlftONryVA9PMu+uvR8DlLNh0aj9h HzlMTAj9fZpe/FRD5Vp+oxMlemoxTdwDTDaKkFOw5qGn7l59vA290u/blxPuOJwp7j +G1rJgU5Mx2j2EX6a3YHeJVI4smIutuvksWzidE0= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 14 Sep 2021 18:37:04 +0200 Message-Id: <20210914163709.85751-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v8 0/5] Move and improve AWB structures X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" On the path towards a cleaner and more documented IPA for the IPU3, this series changes the structures used by the AWB algorithm. - v8 inverts patch 4 and 5 from the previous series, and the final one is now the moving of the new stats structure. And the one before is a rework to make the namings consistent between all algorithms (which leads to a bit more code reworded in AGC). - v7 changes a bit of naming in the Awb::generateAwbStats function to make it even clearer. - v6 adds a real better documentation in the AWB part (thanks Kieran) and properly defines the terms used in the algorithm (cell and zone). A new patch appears which is here to make it consistent. - v5 is a small rewording of the commit messages for 2/4 and 4/4. - v4 changes the way the structure is used in intel-ipu3.h to avoid any change in the buffer size. It should be transparent. Patch 1/5 moves the AWB structures to be able to use those from the ipa::ipu3::algorithms namespace (by AGC at least). Patch 2/5 renames the stats region structure to make it clear it is an accumulator structure. Patch 3/5 is improving the Accumulator structure to have the same layout as the IPAFrameContext::awb structure. Patch 4/5 is a bit reworked and covers Awb and Agc. Awb is only renaming, while Agc should have been only that... if it was not badly written :-). So it has been reworked a bit more. Patch 5/5 is removing the IPU3AwbCell from libcamera, and uses its definition directly from the kernel header. Jean-Michel Hautbois (5): ipa: ipu3: Move the AWB stats structures ipa: ipu3: Rename IspStatsRegion to Accumulator ipa: ipu3: Change Accumulator structure layout ipa: ipu3: Make the naming consistent ipa: ipu3: Replace ipa::ipu3::algorithms::Ipu3AwbCell include/linux/intel-ipu3.h | 28 +++++++- src/ipa/ipu3/algorithms/agc.cpp | 43 +++--------- src/ipa/ipu3/algorithms/awb.cpp | 120 +++++++++++++++++++++----------- src/ipa/ipu3/algorithms/awb.h | 30 +++----- 4 files changed, 128 insertions(+), 93 deletions(-)