From patchwork Mon Sep 13 13:27:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 13822 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 68E29BDC71 for ; Mon, 13 Sep 2021 13:28:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AC0FC6918B; Mon, 13 Sep 2021 15:28:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SIMuhmQ9"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 867406024C for ; Mon, 13 Sep 2021 15:28:06 +0200 (CEST) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:edc5:688b:2ede:8b4b]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E575499; Mon, 13 Sep 2021 15:28:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1631539686; bh=DT9FQRNjnRATy2FIPHMSH7eK4QHtQHoZDYlYTUMTlBo=; h=From:To:Cc:Subject:Date:From; b=SIMuhmQ935zHKoGDmfLFp7AOXbk61KUy11nrqtAU+4fPNBwIhgjwLdDM4XBB90377 6AZv22wCr9vKM17cO9dXExFEVKvMLRVtE3vvEfp5hGU49HdqudGL1F533Aw5dYcZ5I EoCZj38e3Ac9DQZgtzQNGADAE7XgHwv0jVrEgSwo= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Mon, 13 Sep 2021 15:27:58 +0200 Message-Id: <20210913132803.54881-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v7 0/5] Move and improve AWB structures X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" On the path towards a cleaner and more documented IPA for the IPU3, this series changes the structures used by the AWB algorithm. - v7 changes a bit of naming in the Awb::generateAwbStats function to make it even clearer. - v6 adds a real better documentation in the AWB part (thanks Kieran) and properly defines the terms used in the algorithm (cell and zone). A new patch appears which is here to make it consistent. - v5 is a small rewording of the commit messages for 2/4 and 4/4. - v4 changes the way the structure is used in intel-ipu3.h to avoid any change in the buffer size. It should be transparent. Patch 1/5 moves the AWB structures to be able to use those from the ipa::ipu3::algorithms namespace (by AGC at least). Patch 2/5 renames the stats region structure to make it clear it is an accumulator structure. Patch 3/5 is improving the Accumulator structure to have the same layout as the IPAFrameContext::awb structure. Patch 4/5 is removing the IPU3AwbCell from libcamera, and uses its definition directly from the kernel header. And if the cover letter has been read until here, there is no need to present patch 5/5 ;-). Jean-Michel Hautbois (5): ipa: ipu3: Move the AWB stats structures ipa: ipu3: Rename IspStatsRegion to Accumulator ipa: ipu3: Change Accumulator structure layout ipa: ipu3: Replace ipa::ipu3::algorithms::Ipu3AwbCell ipa: ipu3: awb: Make the naming consistent include/linux/intel-ipu3.h | 28 +++++++- src/ipa/ipu3/algorithms/agc.cpp | 7 +- src/ipa/ipu3/algorithms/awb.cpp | 123 +++++++++++++++++++++----------- src/ipa/ipu3/algorithms/awb.h | 30 +++----- 4 files changed, 124 insertions(+), 64 deletions(-)