From patchwork Thu Sep 9 13:54:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 13788 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E432ABDB1D for ; Thu, 9 Sep 2021 13:54:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F25A869172; Thu, 9 Sep 2021 15:54:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NmARbRA0"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A2D66916B for ; Thu, 9 Sep 2021 15:54:54 +0200 (CEST) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:ab35:be36:579e:39cf]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B2F12883; Thu, 9 Sep 2021 15:54:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1631195693; bh=3ArhjCHGz3DsHZVnNUiQ9plRV7v0AH0OURM+6B4SRyY=; h=From:To:Cc:Subject:Date:From; b=NmARbRA0uRmzJeeRoF/Z7JYlWxB+541iTE7mhzn5SoeB+JpHAPQ9rQZD5BNi5r+Eu N/jF7gaYEhusHVE1hIDpJ2QoMVafIohSH/UfIl0xf9NCM4pB+RvGIgf/jFhQ5NKUfs ulgtkm3emj2JXr7wPb6vaq9Pnj/KCAQzx+PsKST0= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Thu, 9 Sep 2021 15:54:44 +0200 Message-Id: <20210909135449.68017-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 0/5] Move and improve AWB structures X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" On the path towards a cleaner and more documented IPA for the IPU3, this series changes the structures used by the AWB algorithm. - v6 adds a real better documentation in the AWB part (thanks Kieran) and properly defines the terms used in the algorithm (cell and zone). A new patch appears which is here to make it consistent. - v5 is a small rewording of the commit messages for 2/4 and 4/4. - v4 changes the way the structure is used in intel-ipu3.h to avoid any change in the buffer size. It should be transparent. Patch 1/5 moves the AWB structures to be able to use those from the ipa::ipu3::algorithms namespace (by AGC at least). Patch 2/5 renames the stats region structure to make it clear it is an accumulator structure. Patch 3/5 is improving the Accumulator structure to have the same layout as the IPAFrameContext::awb structure. Patch 4/5 is removing the IPU3AwbCell from libcamera, and uses its definition directly from the kernel header. And if the cover letter has been read until here, there is no need to present patch 5/5 ;-). Jean-Michel Hautbois (5): ipa: ipu3: Move the AWB stats structures ipa: ipu3: Rename IspStatsRegion to Accumulator ipa: ipu3: Change Accumulator structure layout ipa: ipu3: Replace ipa::ipu3::algorithms::Ipu3AwbCell ipa: ipu3: awb: Make the naming consistant include/linux/intel-ipu3.h | 28 +++++++- src/ipa/ipu3/algorithms/agc.cpp | 7 +- src/ipa/ipu3/algorithms/awb.cpp | 120 +++++++++++++++++++++----------- src/ipa/ipu3/algorithms/awb.h | 30 +++----- 4 files changed, 122 insertions(+), 63 deletions(-)