From patchwork Mon Sep 6 14:01:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 13630 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B139EBDC71 for ; Mon, 6 Sep 2021 14:01:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6C5B66916A; Mon, 6 Sep 2021 16:01:09 +0200 (CEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D424060137 for ; Mon, 6 Sep 2021 16:01:07 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 741914001D; Mon, 6 Sep 2021 14:01:07 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 6 Sep 2021 16:01:47 +0200 Message-Id: <20210906140152.636883-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/5] android: Fix descriptors_ clean up X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While testing Hiro's patch, which I'm re-sending here, I tried as well to centralize the streams_ and descriptors_ cleanup. This lead to the discovery of a potentially missed frame error in CameraWorker. On top of that, I have added two assertions to enforce the correct Camera behavior after a stop() call. Thanks j Hirokazu Honda (1): android: camera_device: Fix crash in calling CameraDevice::close() Jacopo Mondi (4): android: camera_device: Clear streams_ in stop() android: camera_device: Make abortRequest() take a const android: camera_worker: Notify fence wait failures android: camera_device: Assert descriptors_ is empty src/android/camera_device.cpp | 54 ++++++++++++++++++++++++++--------- src/android/camera_device.h | 3 +- src/android/camera_worker.cpp | 10 ++++--- src/android/camera_worker.h | 9 ++++-- 4 files changed, 55 insertions(+), 21 deletions(-) Reviewed-by: Hirokazu Honda Reviewed-by: Hirokazu Honda Reviewed-by: Umang Jain Reviewed-by: Umang Jain Reviewed-by: Umang Jain Reviewed-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- 2.32.0