From patchwork Wed Sep 1 14:37:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 13594 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DF54CBDC71 for ; Wed, 1 Sep 2021 14:37:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 655CB69167; Wed, 1 Sep 2021 16:37:18 +0200 (CEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3818660288 for ; Wed, 1 Sep 2021 16:37:17 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B142DC0009; Wed, 1 Sep 2021 14:37:16 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Wed, 1 Sep 2021 16:37:54 +0200 Message-Id: <20210901143800.119118-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/6] libcamera: control serializer fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This series has started from investigating an error triggered by running consecutive capture sessions with the IPU3 IPA module running in isolation. From there a few more fixes/improvements have lead me to be capable to running CTS with isolated IPA with a single failure (the flaky recording tests). Patch 1 is a small cleanup of the IPU3 IPA interface. Patches 2, 3 and 4 fix issues in the control serializer, most of them went not noticed as the IPA is seldom run isolated for the moment. Patch 5 is a small drive-by change Patch 6 fixes a log standing debt, and add the ability to ser/deser the ControlInfo::def field. Thanks j Jacopo Mondi (6): libcamera: ipu3: Drop entityControls map ipa: proxy_worker: Reset ControlSerializer on worker libcamera: control_serializer: Keep handles in sync libcamera: control_serializer: Use the right idmap libcamera: controls: Rationalize idMap() function libcamera: control_serializer: Serialize info::def() include/libcamera/controls.h | 3 +- include/libcamera/ipa/ipu3.mojom | 2 +- src/ipa/ipu3/ipu3.cpp | 4 +- src/libcamera/camera_sensor.cpp | 2 +- src/libcamera/control_serializer.cpp | 60 +++++++++++++++---- src/libcamera/controls.cpp | 12 +++- src/libcamera/delayed_controls.cpp | 4 +- src/libcamera/ipa_controls.cpp | 14 +++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- .../module_ipa_proxy_worker.cpp.tmpl | 4 ++ 10 files changed, 79 insertions(+), 28 deletions(-) Reviewed-by: Kieran Bingham Reviewed-by: Kieran Bingham Reviewed-by: Kieran Bingham Reviewed-by: Kieran Bingham Reviewed-by: Kieran Bingham Reviewed-by: Paul Elder Reviewed-by: Umang Jain Reviewed-by: Umang Jain Reviewed-by: Paul Elder Reviewed-by: Paul Elder Reviewed-by: Paul Elder Reviewed-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Laurent Pinchart Reviewed-by: Laurent Pinchart --- 2.32.0