From patchwork Tue Aug 31 09:34:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 13579 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8EF3CBD87D for ; Tue, 31 Aug 2021 09:34:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E4D326916A; Tue, 31 Aug 2021 11:34:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="E3oTD1pj"; dkim-atps=neutral Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 33AA860288 for ; Tue, 31 Aug 2021 11:34:46 +0200 (CEST) Received: by mail-pg1-x534.google.com with SMTP id w8so16078809pgf.5 for ; Tue, 31 Aug 2021 02:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wHcJI9iNYWJ8TfdPz/wk1z0mQbGkf3HP1RnI/gfKgxA=; b=E3oTD1pjt5SvwpgdMDDphlhCNNbuJP9ovc2lgAI4JU2GR76wRLkxBuKBU7JRZT7Uk6 YGpiw8+y5JgulOEXhSGZ4XOj/QWHX48ZMVOlUlksQ8uffxD8INM/kd5czOVrq1T8+HA2 UjfkGzl3AH8hsK1LtOOo8MDdpHQh+f4Y+VWWk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wHcJI9iNYWJ8TfdPz/wk1z0mQbGkf3HP1RnI/gfKgxA=; b=PEgZXwUOV0QDH92I7dBWGB1YMtP05GIoGewWYM1ZCSyWna9yQ+TGUG5cqF8Z7F4CRE 7coKF6i55v6SKzQJZF9kNsuA7SIwvGrf10vxHtaZlGDfcmFERalimZt1RXWBTyU0PcTx ldxljyywr0w77OMHVyYgWQULb5NW9JDZbtJSwvv3eBgrP7UMp/8LFEfX8H+xkvTV+Qt7 Ye8g/gZu6Vmrp2lJtdBgZQqpLSXj/iYUbxiffWXGpvo9LcDlxykYSh1MFvyeEX0p+SWj Wa80SzmsGnLDDgtRSzllYFCZjIwSG9W72/53wp/5tJZN7BxsPKe4D8cB3sBjgaE4ntX2 OGQQ== X-Gm-Message-State: AOAM532q5XlIBUEtELMVwakyi7+86UQFrBVjtiDs/2SWEoExohiPFRbr buOcGxjlaPyBwej3aOQ0B2PJ7yodGBKxDg== X-Google-Smtp-Source: ABdhPJwRmyhXCQZQm4R6woRwMFhooKwRZDWcb5JAxHMdkEZtZkVbWzXbqcyuoDGpkm6+EEwVDwxdnA== X-Received: by 2002:a62:6384:0:b0:3eb:13e7:18c with SMTP id x126-20020a626384000000b003eb13e7018cmr27758003pfb.73.1630402484261; Tue, 31 Aug 2021 02:34:44 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:203:3c62:aba4:18ea:5441]) by smtp.gmail.com with ESMTPSA id w5sm19787885pgp.79.2021.08.31.02.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 02:34:43 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 31 Aug 2021 18:34:36 +0900 Message-Id: <20210831093439.853586-1-hiroh@chromium.org> X-Mailer: git-send-email 2.33.0.259.gc128427fd7-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/3] android: Request one stream for identica stream requests X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Android HAL client may request multiple streams, whose formats and resolutions are same. This patch series confgiures one stream for the identical stream requests so that the requests can be accepted as much as possible. With this patch series, 10 tests out of 18 CTS tests requesting multiple streams newly pass. [1/18] android.hardware.camera2.cts.RobustnessTest#testMandatoryOutputCombinations pass [2/18] android.hardware.cts.CameraTest#testFocusDistances pass [3/18] android.hardware.cts.CameraTest#testImmediateZoom fail [4/18] android.hardware.cts.CameraTest#testPreviewCallback pass [5/18] android.hardware.cts.CameraTest#testPreviewCallbackWithBuffer fail [6/18] android.hardware.cts.CameraTest#testPreviewCallbackWithPicture pass [7/18] android.hardware.cts.CameraTest#testPreviewFormats pass [8/18] android.hardware.cts.CameraTest#testPreviewFpsRange pass [9/18] android.hardware.cts.CameraTest#testPreviewPictureSizesCombination fail [10/18] android.hardware.cts.CameraTest#testSetOneShotPreviewCallback pass [11/18] android.hardware.cts.CameraTest#testSetPreviewDisplay pass [12/18] android.hardware.cts.CameraTest#testVideoSnapshot fail [13/18] android.hardware.cts.CameraGLTest#testSetPreviewTextureBothCallbacks pass [14/18] android.hardware.cts.CameraGLTest#testSetPreviewTexturePreviewCallback pass [15/18] android.hardware.multiprocess.camera.cts.CameraEvictionTest#testMediaRecorderCameraActivityEviction fail [16/18] android.hardware.camera2.cts.StillCaptureTest#testStillPreviewCombination fail [17/18]android.hardware.camera2.cts.SurfaceViewPreviewTest#testDeferredSurfaces fail [18/18] android.hardware.camera2.cts.ImageReaderTest#testAllOutputYUVResolutions fail I found sometimes more tests failed (only 5 test passes for example). I am looking into the issue. But in my humble opinion, this patch series doesn't cause make things worse and therefore okay to be merged. change in v3: - Address Jacopo's comments change in v2: - Address Jacopo's comments Hirokazu Honda (3): android: camera_stream: Create post processor in configure() android: camera_stream: Support PostProcessorYuv in CameraStream android: camera_device: Configure one stream for identical stream requests src/android/camera_device.cpp | 28 ++++++++++++++++---- src/android/camera_device.h | 1 + src/android/camera_stream.cpp | 50 +++++++++++++++++++++-------------- 3 files changed, 54 insertions(+), 25 deletions(-) --- 2.33.0.259.gc128427fd7-goog