From patchwork Mon Aug 30 08:21:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13567 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 923C6BD87D for ; Mon, 30 Aug 2021 08:22:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 420C56916C; Mon, 30 Aug 2021 10:22:00 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="AKVtr1bo"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AB49F68934 for ; Mon, 30 Aug 2021 10:21:56 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.0]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A6A683D7; Mon, 30 Aug 2021 10:21:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1630311716; bh=PaTGFqP8EpOgdFfxq2pPClrEPQ6u4ekB9nP1zZgFggQ=; h=From:To:Cc:Subject:Date:From; b=AKVtr1bok4u76NQMrY2NaHhrWP4gGzaWMIU94WPRMhw8UiUHV85fg8FyPyfhB+fqB 8nrac9rnBvA+Sz7YxTW7vWXQltVf6MrtggerCW7db68g7xnlSC8y18wwg7/aJlfBRu Bg7UR56Qs9owo98NtX50fOfLPlfrrI6ytlK6zeCQ= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Mon, 30 Aug 2021 13:51:46 +0530 Message-Id: <20210830082150.42514-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/4] ipu3: Change sensor size selection policy X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The series is geared towards addressing sensor selection constraints on soraka and nautilus. 1/4 and 2/4 prepares the base to highlight the change in selection policy. 3/4 and 4/4 is the actual change. The constraints are documented in the commit messages of 3/4 and 4/4. Changes in v3: - Minor for loop matching change in 1/4 - Remove author's "Tested-by" tags (mainly were added since I was testing CTS rigoursly) - Descriptive comment on ratio diffs in 4/4 - Few commit typo fixes Changes in v2: - 1/4 also sees the change in CIO2Device::sizes to CIO2Device::sizes(pixelFormat). - Use std::numeric_limits<> in 2/4. Include otherwise compilation breaks on gcc. - Few wordings restructure. Umang Jain (4): libcamera: camera_sensor: Transform CameraSensor::sizes() ipu3: cio2: Replicate CameraSensor::getFormats() to a member function ipu3: cio2: Change sensor size selection policy ipu3: cio2: Tweak sensor size selection policy include/libcamera/internal/camera_sensor.h | 2 +- src/libcamera/camera_sensor.cpp | 25 ++++- src/libcamera/pipeline/ipu3/cio2.cpp | 125 ++++++++++++++++++++- src/libcamera/pipeline/ipu3/cio2.h | 5 +- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- test/camera-sensor.cpp | 2 +- 6 files changed, 145 insertions(+), 16 deletions(-)