From patchwork Sat Aug 14 05:09:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13353 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B7064BD87D for ; Sat, 14 Aug 2021 05:09:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 410BB6888D; Sat, 14 Aug 2021 07:09:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GgnCHoN+"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 032B76025E for ; Sat, 14 Aug 2021 07:09:23 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.70]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B63FE3E5; Sat, 14 Aug 2021 07:09:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628917763; bh=bB/WQvLlmCVODIQheOYLmphIstprWKaAd6VxTxR5pPg=; h=From:To:Cc:Subject:Date:From; b=GgnCHoN+uHkGuK6sqaDZjOU6n41OnkVWRoDdihSZnBGneKlpCiSyyUyXUzREbP9Vd 523uFXqpFwCHUNU2qGgu7hb6FevlzetHgMhkvhYSlDM6rAg5ICVBzybyErephnMmbX qeEs5IBW7lzYFgdFF0d3w2SQ4pUfJCUlBh0X2jZs= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Sat, 14 Aug 2021 10:39:08 +0530 Message-Id: <20210814050912.15113-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/4] Pass buffers to VIMC IPA X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Currently, there is no buffer passing on VIMC happening. VIMC being a virtual test driver, doesn't have actual parameter or statistics buffers. But that shouldn't stop us leveraging VIMC for IPA IPC testing. We will create mock dmabuf buffers using the video output node. We will configure it with a single plane, small size V4L2DeviceFormat and export buffers from there. This happens during init(), so the actual requested configuration happens during the normal configure()(We just hijack the video output node for a while temporarily). This is the major change in v2. Other changes: - Drop Actions and Events paradigm, use dedicated functions for operations via mojom interface. - style check in 1/4 and 3/4 - commit messages rework Changes in v3: - Transform loops with better iteration options - Drop V4L2VideoDevice::tryFormat() in 2/4 - Drop VimcCameraData::ipaBuffers_ in favor a local scoped vector 3/4 - Commits and comments rework Laurent Pinchart (1): ipa: vimc: Add configure() function Umang Jain (3): pipeline: vimc: Allocate mock IPA buffers ipa: vimc: Map and unmap buffers ipa: vimc: Send and retrieve FrameBuffers from IPA include/libcamera/ipa/vimc.mojom | 19 +++++++- src/ipa/vimc/vimc.cpp | 59 +++++++++++++++++++++++++ src/libcamera/pipeline/vimc/vimc.cpp | 65 ++++++++++++++++++++++++++++ 3 files changed, 142 insertions(+), 1 deletion(-)