From patchwork Thu Jul 8 08:21:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12865 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CB673C3224 for ; Thu, 8 Jul 2021 08:21:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4B64768513; Thu, 8 Jul 2021 10:21:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QneyZ2D/"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B620F68509 for ; Thu, 8 Jul 2021 10:21:55 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.59]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A0BCE7; Thu, 8 Jul 2021 10:21:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1625732515; bh=9FQwHmhUrer9fh7MGrGdR/3ZbZkMR/1btVqpNpf68CE=; h=From:To:Cc:Subject:Date:From; b=QneyZ2D/XLZuHXDzEO5Vetdmo0TVWFaTTt/UjSLCv9/DozF6R0l+FgrOIWlKOIW2M PDhL9QQl4nPaHz7oA62XV7KeyMb+HXHgjf564tP/JiJ/bLLlyGawBxsurH/Lx0/uRo ZLM9aoNQWw6m0WDDn2OhKj/XbP1XKSgGoRyX89XY= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Thu, 8 Jul 2021 13:51:43 +0530 Message-Id: <20210708082145.122160-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] utils: ipc: proxy: Always reset ControlSerializer during IPA configure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This is a small patch which seems to fix issue highlighted by: https://bugs.libcamera.org/show_bug.cgi?id=58 1/2 is a DNI, which can help for logging in isolated IPA mode. However, while testing this series with CTS, a new issue has been identified related to open/lingering fds. For what I can see, it is unrelated to this fix. So expect that some CTS tests will fail still in isolated mode, but hopefully Bug#58 behaviour isn't reproduced, if you carry this change. The new issue, if you get hit, might be along these lines: (In isolated IPA log) [0:20:15.723915030] [10202] FATAL FileDescriptor file_descriptor.cpp:235 Failed to dup() fd: Too many open files Backtrace: (cros_camera_service) [0:20:17.724419941] [10201] ERROR IPCPipe ipc_pipe_unixsocket.cpp:134 Call timeout! [0:20:17.724586917] [10201] ERROR IPCPipe ipc_pipe_unixsocket.cpp:66 Failed to call sync [0:20:17.724612298] [10201] ERROR IPAProxy ipu3_ipa_proxy.cpp:338 Failed to call mapBuffers ... [0:20:27.200651034] [10201] ERROR IPCPipe ipc_pipe_unixsocket.cpp:66 Failed to call sync [0:20:27.200667808] [10201] ERROR IPAProxy ipu3_ipa_proxy.cpp:288 Failed to call configure [0:20:27.200684272] [10201] ERROR IPU3 ipu3.cpp:648 Failed to configure IPA: Connection timed out ... More CTS test failures down the line. Umang Jain (2): DNI: Enforce IPA isolation and set log file path utils: ipc: proxy: Always reset ControlSerializer during IPA configure src/ipa/ipu3/ipu3.cpp | 2 ++ src/libcamera/ipa_manager.cpp | 1 + .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 4 ++++ 3 files changed, 7 insertions(+)