From patchwork Fri Jul 2 10:37:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 12765 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1A20EC3222 for ; Fri, 2 Jul 2021 10:38:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 758EC684E8; Fri, 2 Jul 2021 12:38:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ervx12Cp"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D395C684E7 for ; Fri, 2 Jul 2021 12:38:12 +0200 (CEST) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5571D4AB; Fri, 2 Jul 2021 12:38:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1625222292; bh=xL6jR22S7AAZx/DOPC2LmCMes45C305yz1vv92lmIx0=; h=From:To:Cc:Subject:Date:From; b=ervx12CpZrl7OTRhAx2+EZ/MV+qCxX/Io0P9xbHEYxBjCHsa62uUyTJwLL/4nGkj8 4IDCczCr880e9qesASuogLurCU88ne8AZ4xLxHPPh8yfD2n1RGuBPlW5Hijj5c+MBI 45/Prqv7VbnIFHvMAaJ8ib/vgexZ8IZxJcSk4xmA= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Fri, 2 Jul 2021 19:37:44 +0900 Message-Id: <20210702103800.41291-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH v3 00/16] Preliminary FULL plumbing X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series adds controls and plumbing necessary for 5 controls to satisfy FULL requirements: - AeLock - AeEnable (AE_MODE) - AwbLock - AwbMode - MaxLatency (SYNC_MAX_LATENCY) v2 has been skipped. New in v3, 1/16 adds a constructor for ControlInfo that takes boolean values. Patch 2/16 has the plumbing for capability detection. New in v3, patch 3/16 adds helpers for setting android metadata for libcamera controls, to help keep the HAL capability tracking cleaner. Patches 4/16 to 7/16 add the necessary controls. Patches 4/16 and 8/16 to 11/16 plumb the controls into the HAL. They all plumb into the static metadata, and only a few into the result metadata. Patches 12/16 to 16/16 plumb the controls into the IPU3 pipeline handler. As for IPA capability discovery, I think we can simply do an extension of what I have on 12/16 to 16/16 on IPU3, just one layer over. It was hard to gauge the desires for the lock controls, so there aren't really any changes there. Paul Elder (16): controls: Add boolean constructor for ControlInfo android: Add infrastructure for determining capabilities and hardware level android: Add helpers for setting android metadata from libcamera controls android, controls: Add and plumb MaxLatency control controls: Replace AeLocked with AeState, and add AeLock controls: Replace AwbEnable with AwbMode controls: Replace AwbLocked with AwbState, and add AwbLock android: Plumb AeEnable control android: Plumb AeLock control android: Plumb AwbMode control android: Plumb AwbLock control pipeline: ipu3: Set MaxLatency ControlInfo FULL: pipeline: ipu3: Set AeEnable ControlInfo pipeline: ipu3: Set AeLock ControlInfo pipeline: ipu3: Set AwbMode ControlInfo pipeline: ipu3: Set AwbLock ControlInfo include/libcamera/controls.h | 1 + include/libcamera/ipa/raspberrypi.h | 1 - src/android/camera_capabilities.cpp | 266 +++++++++++++++++++++++---- src/android/camera_device.cpp | 6 +- src/ipa/raspberrypi/raspberrypi.cpp | 32 ++-- src/ipa/rkisp1/rkisp1.cpp | 13 +- src/libcamera/control_ids.yaml | 220 +++++++++++++--------- src/libcamera/controls.cpp | 20 ++ src/libcamera/pipeline/ipu3/ipu3.cpp | 6 + test/controls/control_list.cpp | 6 +- 10 files changed, 424 insertions(+), 147 deletions(-)