From patchwork Tue Jun 22 13:20:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12681 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E1E7AC321B for ; Tue, 22 Jun 2021 13:20:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D02AF6893C; Tue, 22 Jun 2021 15:20:22 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="BWvF/0nd"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FA5160292 for ; Tue, 22 Jun 2021 15:20:20 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id j21-20020a05600c1c15b02901dde2accccbso2238230wms.4 for ; Tue, 22 Jun 2021 06:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2tczdIYqHtHFR1mRHRjxoOQNwgzL1thwZCrJ3kNeMJs=; b=BWvF/0nd4P9uX6i/Qo2BK9oLaRepTbqfhaX3tR9zLFLBILZmNsrzwmbDkORPCyqI7P tAJVYPq59frjyTJqTGa9gyMv87n8tcwwmM4jWoXMA4M+lhDqwHIpranT8Dfm0Dvxn/RG WKzoyZML1k1TXr4ZSDKQPJnFFuS5Q6+8Ax6UXHRsJwIo8MvZbYzEKu4oQeJZPxcDzPu0 wP6SK63RswkMYRfVz8wvoz9gACYG8/CXSFvawFpCbEJ3Jr1wTvcOe2j7Es4H5HeV71pO YIZU5fHdlIIwafIwal7rOuoeV4b/Teikn7mVMq4L5lvJ/7S25BXlTJ7VLU53bjE6txSO 4uxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2tczdIYqHtHFR1mRHRjxoOQNwgzL1thwZCrJ3kNeMJs=; b=Zg6SE2hV+OokT3ZSIwptmWl5jEyeeLfIMOQwksAhB9/vbUyrU1pCh4Y9ePYJZRYXjv g50C4Xrkjf6DlKO+ZH98Sl/NNnTeEbMN20Mv2e6ptuFO6e1PEc215HXSFszVNkJv+08N 76E7C+/p6sTZ9aeicdN+OgUnbyfx8fMDJVan6AeL8/hGlOsmLS+0QXUmXOdzyK6dllye 8HtjgT3QOHoQ0xTL+ofvYWlu42Gc6Jaj4DvRGwEGAEEc6JIm6D3eSVLHsHzKns4oYP6n NFD7c8fcxAneyatNHgE8ZQXQSuhgR17swNLtcqC3iRuDX9Q799FVdpYHKIeHeLpEn9Dz 0TZQ== X-Gm-Message-State: AOAM531TviuEqeXIFmbW5ZFmsoTaNEX3NbLj7uReOGQfNwTAkrCuat7k Ai85JNONsKl5ZpDKwRouDLfAhrrIIzLIWQ== X-Google-Smtp-Source: ABdhPJwdIUvRpZ4iqrB/bMzjjinKbje+1suVuKn6WHjsOhFLrm8loXCzYnc7MirL6I+dpDYGQdxZjw== X-Received: by 2002:a7b:cc10:: with SMTP id f16mr4437015wmh.24.1624368020354; Tue, 22 Jun 2021 06:20:20 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:28d:3aa5:c82:cbf1]) by smtp.gmail.com with ESMTPSA id k5sm2632213wmk.11.2021.06.22.06.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 06:20:19 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 22 Jun 2021 14:20:12 +0100 Message-Id: <20210622132014.949961-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] Raspberry Pi: Metadata parsing improvements (II) X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Here is version 2 of this series. The following changes have been introduced over v1: - Rework patch 1/2 to use a unique_ptr to store the parser object in the CamHelper class. - Switch to using std::initialiser_list in the constructor of MdParserSmia. - All suggestions from Laurent's feedback have been addressed in patch 2/2. The constructor for the unique_ptr in patch 2/2 looks a bit awkward now since I have to explicitly write std::initialiser_list within std::make_unique, but I cannot see nice way around this. I have removed all previous tags from 1/2, as this is a completely different approach to the previous revision. Thanks, Naush Naushir Patuck (2): ipa: raspberrypi: Use a unique_ptr for the metadata parser ipa: raspberrypi: Generalise the SMIA metadata parser src/ipa/raspberrypi/cam_helper.cpp | 38 ++++--- src/ipa/raspberrypi/cam_helper.hpp | 7 +- src/ipa/raspberrypi/cam_helper_imx219.cpp | 117 ++++---------------- src/ipa/raspberrypi/cam_helper_imx290.cpp | 2 +- src/ipa/raspberrypi/cam_helper_imx477.cpp | 123 ++++------------------ src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +- src/ipa/raspberrypi/md_parser.hpp | 42 +++++--- src/ipa/raspberrypi/md_parser_smia.cpp | 66 ++++++++++-- 8 files changed, 155 insertions(+), 242 deletions(-)