From patchwork Fri Jun 18 10:33:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 12633 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5F122BD78E for ; Fri, 18 Jun 2021 10:34:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0FBE660298; Fri, 18 Jun 2021 12:34:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rfU8FMHV"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CE8A660298 for ; Fri, 18 Jun 2021 12:34:01 +0200 (CEST) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2AC6A3E5; Fri, 18 Jun 2021 12:33:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624012441; bh=IXwFkFemuwsfStZjWTrbP1Topre8O8isN6n97iLtiAo=; h=From:To:Cc:Subject:Date:From; b=rfU8FMHV+bM47OZqGvv9cLH1JIS17i+msVFBkqB7vmUQenJItPr205ZgXR5z3eZBi D+L72xIp/KRyh0K4v+3x9M4S7gZ/NUmAGnLnP/cySMN8GeVDGJNKkncDPcmtGZFy3+ HH4CdKFqCU928I1+ao7aURCgPuH4taJL6Mojj2zk= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Fri, 18 Jun 2021 19:33:37 +0900 Message-Id: <20210618103351.1642060-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 00/14] Preliminary FULL plumbing X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series adds controls and plumbing necessary for 5 controls to satisfy FULL requirements: - AeLock - AeEnable (AE_MODE) - AwbLock - AwbMode - MaxLatency (SYNC_MAX_LATENCY) Patch 1/14 has the plumbing for capability detection. It does not need to be reviewed; it is only included for dependency resolution. Patches 2/14 to 5/14 add the necessary controls. Patches 2/14 and 6/14 to 9/14 plumb the controls into the HAL. They all plumb into the static metadata, and only a few into the result metadata. Patches 10/14 to 14/14 plumb the controls into the IPU3 pipeline handler. As for IPA capability discovery, I think we can simply do an extension of what I have on 10/14 to 14/14 on IPU3, just one layer over. I hope that the patches for the HAL plumbing can give us some insight to the requirements of the refactor capability manager. Paul Elder (14): android: Add infrastructure for determining capabilities and hardware level android, controls: Add and plumb MaxLatency control controls: Replace AeLocked with AeState, and add AeLock controls: Replace AwbEnable with AwbMode controls: Replace AwbLocked with AwbState, and add AwbLock android: Plumb AeEnable control android: Plumb AeLock control android: Plumb AwbMode control android: Plumb AwbLock control FULL: pipeline: ipu3: Set MaxLatency ControlInfo FULL: pipeline: ipu3: Set AeEnable ControlInfo FULL: pipeline: ipu3: Set AeLock ControlInfo FULL: pipeline: ipu3: Set AwbMode ControlInfo FULL: pipeline: ipu3: Set AwbLock ControlInfo include/libcamera/ipa/raspberrypi.h | 1 - src/android/camera_device.cpp | 121 ++++++++++++--- src/ipa/raspberrypi/raspberrypi.cpp | 32 ++-- src/ipa/rkisp1/rkisp1.cpp | 13 +- src/libcamera/control_ids.yaml | 220 +++++++++++++++++---------- src/libcamera/pipeline/ipu3/ipu3.cpp | 5 + test/controls/control_list.cpp | 6 +- 7 files changed, 262 insertions(+), 136 deletions(-)