From patchwork Tue Jun 15 14:42:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12603 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0B771C3218 for ; Tue, 15 Jun 2021 14:42:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0152168948; Tue, 15 Jun 2021 16:42:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="hBYiolDn"; dkim-atps=neutral Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 34D176029A for ; Tue, 15 Jun 2021 16:42:15 +0200 (CEST) Received: by mail-wm1-x333.google.com with SMTP id d184so14311901wmd.0 for ; Tue, 15 Jun 2021 07:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ya1OGv6WvUPtrKAhEqGmyHYL6vUsJ0wx5Y/PgFI4Tyc=; b=hBYiolDnL8ZZ6Szstt2g0vUSCnAaJYViXXtiwZYhYz9VndS09dqKblmIpWQaPIU0RG hHyTo1fOWeKci/hIpnCuwIJ4YdwsL1e+OpezZc9og6SY9EgL5F6FcSSyvS6cbmTC8AkP WRQr0wDaOZJ7CZikIqYx1j5TuRLIw1Ks/hf8mvjpDgu9e3VlXeC1qqxmThPWV+sYlNMl wZdk4dxT00Fz627qVkLrQqttBx9UVtQ1iunUiyVQFN0SYAdI+9L+SmnCMzyzuxy1PiG2 f+v6gV9UQCd70/vHlURpU9cYVDCC83v6dLJZAz1mmIdpdxm8EF04itUd2uhnHJcSQyaL DnXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ya1OGv6WvUPtrKAhEqGmyHYL6vUsJ0wx5Y/PgFI4Tyc=; b=geURHxyT3yCJSKxyk/5VCxQQyyTaJCrV+aPL2epuUm7IM/Wsfplpzd2IY+8D/jjETO OOKe/MACjzYYojO8gI8NLhidbkLaIMM9/BRM4TR87Jtzm2lsrybi4gXDiNJP3tvCSKuV 28mO0nsUYMnIh9jYS0wS4koY99ncPTxYsYFnA6YHmFO8zp83KN7RZUHpyXUrsFdFZPPa 00F5ghkKnC5tHvJwp+TRXiS28IeHo5NKumcipvoI9Btlv33LP9VDxRrrYrU27sSntNOM HXlvnVFqZ28dLdTAOGcqIIgj2k6xiomoI7Xf6NmX83tvfnBUNA+45KwTrJP8uqV3+O9w UftQ== X-Gm-Message-State: AOAM532ENekDU4mw1joPO3luQQKjjY4mQcEvVfyKQAzwrlQxy8lZIOvX U1XLVVk9Aa5RzJzP8lqSgEUZTW+kh+T7Bg== X-Google-Smtp-Source: ABdhPJyplGDgyAaAlpitkBd1Gti4R5TwMxZjM5DVOdA9fxpngHLf01szGXHOxFNzQd5Pj+qR0M46gg== X-Received: by 2002:a05:600c:c7:: with SMTP id u7mr22874390wmm.178.1623768134396; Tue, 15 Jun 2021 07:42:14 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:5904:b958:1fd:d555]) by smtp.gmail.com with ESMTPSA id k12sm2441142wmr.2.2021.06.15.07.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 07:42:14 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 15 Jun 2021 15:42:08 +0100 Message-Id: <20210615144211.173047-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/3] Raspberry Pi: Metadata parsing improvements (II) X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This is a new patch series that replaces the old one at: https://patchwork.libcamera.org/project/libcamera/list/?series=2128 This series is rebased on top of the 4 patches merged from the earlier series, along with the following changes: - Patch 1/3 uses the constructor initialiser list to return the pointer to the parser to the base class (as we did previously). - I have separated out the buffer overrun test change into its own patch (2/3). - Reworked patch 3/3 to add a more explicit distinction in the parser between parsing for register offsets and using register values to obtain exposure/gain values. This change is based on Laurent's feedback on the earlier series, and I am happy to take suggestions on how this could be improved. Thanks, Naush Naushir Patuck (3): ipa: raspberrypi: Embed the metadata parser in the sensor CamHelper classes ipa: raspberrypi: Fix possible buffer overrun in metadata parsing ipa: raspberrypi: Generalise the SMIA metadata parser src/ipa/raspberrypi/cam_helper.cpp | 36 ++++--- src/ipa/raspberrypi/cam_helper.hpp | 2 + src/ipa/raspberrypi/cam_helper_imx219.cpp | 118 +++++--------------- src/ipa/raspberrypi/cam_helper_imx477.cpp | 124 +++++----------------- src/ipa/raspberrypi/md_parser.hpp | 42 +++++--- src/ipa/raspberrypi/md_parser_smia.cpp | 70 +++++++++--- 6 files changed, 152 insertions(+), 240 deletions(-)