From patchwork Mon Jun 14 09:53:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12580 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A2686C3218 for ; Mon, 14 Jun 2021 09:53:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 58CC368934; Mon, 14 Jun 2021 11:53:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="o4a1HSeg"; dkim-atps=neutral Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 15F856029A for ; Mon, 14 Jun 2021 11:53:46 +0200 (CEST) Received: by mail-wr1-x433.google.com with SMTP id r9so13838846wrz.10 for ; Mon, 14 Jun 2021 02:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8ZEVK6qMZfrgVJ/LteXvQzQyZx98YGmbqkk/7A0s7RA=; b=o4a1HSeguYP8dMFITtyacmQKeWv+Ujku0OKFCZBVDCA3EtB2O0hJtCEKbMrro0Oyt3 x2nAcjuHa53/hR+Z1IBQ2ubqtpgKmOv/aVgIUpG+RdtvQXfXjlUekM6TYzWPUmhZHzC7 yTiS2nhZQe8/6gIZs6DWwB7OMu9GZVl9EVuvFg4l1sNMrGFQd4XReM0ccbmZ4I4l1UWo 7zML4e3gGSriGO4aefTtNIRzhCSQDGStMYdIpvv9UWFMDJuziZJkBomO1SWPf72DSNOk +duY3yWh7xieEX8vMvp6C+2dsoVgfCRO4HcWHWXDaHamLV+R38QNE9nqqSZc8SQMj4HI Zlhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8ZEVK6qMZfrgVJ/LteXvQzQyZx98YGmbqkk/7A0s7RA=; b=fhf5KNK0OCC0RfsnC7AN+48+sD7LjMHHnqN7aTuRxEAJDGk+VgFxWCvW+lCcVDUss9 eWbqFzhFzd/z2yEidNHHPWgN4HD7T2+RihMDbTt7tcoviP3PJT6KezfVdkvcKXfHunMJ YlMCEirkW6K/sVom3+LUHBSlrlYXu6AQii7CVNR1entZQwF2bNFw4rlj3deVdeSVCLfj Olix3C6dlLADGdRiMxAPEDuiS53BRth13+ekVvdUXF5/miGRwdW43XzugFVg7XsVlDEQ sTHMbnBs09PHCp7TjyCx7150zc7BhTYDclckcMBdxuXG51wuJ4fUV6uXJVtylaScGoKr dxoA== X-Gm-Message-State: AOAM531FS/Jx/1YN9ylpfNoOZSPftYR34DTj7nSFROIxuajq/1NtZIWi dUKDRGSQQnrRnxSinJ8i0jq3nLefT0OuhQ== X-Google-Smtp-Source: ABdhPJwvTJMaCchcWIs4LWpZOOjPbV2YE5caZ7iUUmTQo1PjaUvSKWmUykdrr4LKe7sXwSTal1PLHA== X-Received: by 2002:adf:f946:: with SMTP id q6mr17154566wrr.283.1623664425524; Mon, 14 Jun 2021 02:53:45 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:fd93:d554:2dff:83ca]) by smtp.gmail.com with ESMTPSA id c2sm19834891wmf.24.2021.06.14.02.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 02:53:45 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 14 Jun 2021 10:53:34 +0100 Message-Id: <20210614095340.3051816-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/6] Raspberry Pi: Metadata parsing improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This series of patches provide some improvements to our SMIA metadata parser that were long on my todo list. Patches 1/6 to 4/6 are mostly formatting and syntactic changes to get us more in-line with libcamera formatting guidelines. Patch 5/6 inlines the SMIA parser in all CamHelpers that use time instead of dynamically allocating the object. Patch 6/6 makes the SMIA metadata parser code more generic so that it can be directly used by the imx477 and imx219 CamHelpers instead of being subclassed. Thanks, Naush Naushir Patuck (6): ipa: raspberrypi: Non-functional formatting fixes to md_parser.hpp ipa: raspberrypi: Set default values for member variables of MdParser ipa: raspberrypi: Rename md_parser.cpp to md_parser_smia.cpp ipa: raspberrypi: Non-functional formatting fixes to md_parser_smia.cpp ipa: raspberrypi: Embed the metadata parser in the sensor CamHelper classes ipa: raspberrypi: Generalise the SMIA metadata parser src/ipa/raspberrypi/cam_helper.cpp | 5 +- src/ipa/raspberrypi/cam_helper.hpp | 2 +- src/ipa/raspberrypi/cam_helper_imx219.cpp | 123 +++------------ src/ipa/raspberrypi/cam_helper_imx290.cpp | 2 +- src/ipa/raspberrypi/cam_helper_imx477.cpp | 127 +++------------ src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +- src/ipa/raspberrypi/md_parser.cpp | 102 ------------- src/ipa/raspberrypi/md_parser.hpp | 178 ++++++++++++++-------- src/ipa/raspberrypi/md_parser_smia.cpp | 171 +++++++++++++++++++++ src/ipa/raspberrypi/meson.build | 2 +- 10 files changed, 340 insertions(+), 374 deletions(-) delete mode 100644 src/ipa/raspberrypi/md_parser.cpp create mode 100644 src/ipa/raspberrypi/md_parser_smia.cpp Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart