From patchwork Mon May 31 02:07:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12473 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 28C1EC3206 for ; Mon, 31 May 2021 02:08:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7B8AE68927; Mon, 31 May 2021 04:08:00 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YRfcWz3J"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F95F6891E for ; Mon, 31 May 2021 04:07:58 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BFBCD8AB for ; Mon, 31 May 2021 04:07:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1622426878; bh=1m5DlAbZ4Rp5hlB5EQuKTjYPN6mzyPUTtYx2cBLYBMQ=; h=From:To:Subject:Date:From; b=YRfcWz3JIi11uJVfchl1LTcFpr+BiHbXwTfQuI74nwawuY1CZHnq29hezIIWfg5Jk 7dERa2c1DiiQrQg99plO4kZi8vRQhBicNU9gBUbQF+LOSDwBCtSyIqbG+PcvKYJFnn T2YE4A9joYlx/KMZizMewuYUx4zALJ3sQ7OFncy8= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Mon, 31 May 2021 05:07:43 +0300 Message-Id: <20210531020745.13815-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] Fix gcc warning in IPU3 pipeline handler X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This patch series fixes a gcc warning in the IPU3 pipeline handler. The warning is described in both patches. I believe this to be a false positive, but it still points to an issue in the code. Patch 1/2 fixes the issue, which also gets rid of the warning. However, this modifies the IPU3 BDS height calculation, which can result in unwanted side effects (the code is quite fragile and very far from correct). Patch 2/2 takes a different approach and just silences the warning, leaving the incorrect BDS height calculation to be addressed later. Only one of the two patches should be merged now. In addition to reviewing the them, I'll thus ask you to vote for your favourite candidate :-) Laurent Pinchart (2): libcamera: pipeline: ipu3: Fix incorrect bdsHeight calculation libcamera: pipeline: ipu3: Fix warning when compiled with optimization src/libcamera/pipeline/ipu3/imgu.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)