From patchwork Wed May 26 08:46:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 12423 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D729BC3200 for ; Wed, 26 May 2021 08:46:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3BD9568922; Wed, 26 May 2021 10:46:37 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="l/sYo+Km"; dkim-atps=neutral Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 92C786891E for ; Wed, 26 May 2021 10:46:36 +0200 (CEST) Received: by mail-pf1-x433.google.com with SMTP id c12so428746pfl.3 for ; Wed, 26 May 2021 01:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=X4Z0sqJFYB5zlBjDRzZL7wBLEd30d1rThMY8GtRA/zo=; b=l/sYo+KmI0EJtrt3Q+/4/IaQsxG9nPJ2mvgeO9KwnJDeex1HaPUeIr4DJHR8UoESC2 s9+ZCS/2GczEFKdnsH7KkRRyD+2GNtsDjPgXT2A+tgYhv5JaZnZuSdOlyFwSzxBWmwc6 /Yp5TOerL5ChF/FVsT8O9BxV67oH91Pf1eTPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=X4Z0sqJFYB5zlBjDRzZL7wBLEd30d1rThMY8GtRA/zo=; b=bdU2D+cu7Yeff2kzZPOXR//v2m+oG0FigR7mIEmw7mT5H9S3cD7RKfENVHCirsir2i JKWOC9oRWE3676WaVPY5VrxMHgDi/HCInXAdJL+oPqaIKQ9BG85Pfdo7A4zTfdgOffJI cqBph9te6EIB0uHLxeccq6fY9lui+TQhYFZUOrmj12EJ8y06Lt9ORe9z2TtfPbF51QcM D2S9MXGUD1UHVQbNMGo1y1bidVLEpCyfoXgg7fcXekBFlch8iKKuzd4xETdHihllEq6t MbxMy5fSNnAtQVLJzvLr33sHG7rAt9d1Rkf309NPRb35005DOQvVlw/r0c0rzh6jSEbl mSWg== X-Gm-Message-State: AOAM531iM/WsVimnXWJRagA7qbEVGBe/NcS/RfN/SBqEnQBK7T2cmwXF ebI8eX0MESBCwfxqqkLjD1NwGke1OxBfSg== X-Google-Smtp-Source: ABdhPJzw3NGheuqt6rTOl8DC49REh8vCULEqJMUGFmdQZjEOVWD69VwMKOcQKQmXrvyWDlj/ZX334A== X-Received: by 2002:a62:541:0:b029:2dc:9e95:95cc with SMTP id 62-20020a6205410000b02902dc9e9595ccmr34382462pff.79.1622018794601; Wed, 26 May 2021 01:46:34 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:e36c:ae58:48e5:2f8e]) by smtp.gmail.com with ESMTPSA id w125sm15346886pfw.214.2021.05.26.01.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 May 2021 01:46:34 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Wed, 26 May 2021 17:46:27 +0900 Message-Id: <20210526084628.3893266-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.1.818.g46aad6cb9e-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/1] Fix SIGSEGV in ChromeOS camera3 test X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" SIGSEV is caused in the termination of ChromeOS camera3 test. It is because CameraHalManager touches, through CameraManager, other static objects that have been destroyed. This series fixes the issue by destroying CameraHalManager in tear_down() on ChromeOS or leaking it on other platforms. Change in v2: - Keep src/android/cros/camera3_hal.cpp built independently by including android_includes and libcamera_includes. Hirokazu Honda (1): android: CameraHalManager: Create a static object dynamically src/android/camera3_hal.cpp | 13 ++++++------- src/android/camera_hal_manager.cpp | 7 +++++++ src/android/camera_hal_manager.h | 5 ++++- src/android/cros/camera3_hal.cpp | 3 +++ src/android/cros/meson.build | 3 ++- 5 files changed, 22 insertions(+), 9 deletions(-) --- 2.31.1.818.g46aad6cb9e-goog