From patchwork Wed May 26 00:08:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12414 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8588BC3200 for ; Wed, 26 May 2021 00:09:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9D26068925; Wed, 26 May 2021 02:09:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kVRPWdQH"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 05E5E601AA for ; Wed, 26 May 2021 02:09:05 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F0F0332 for ; Wed, 26 May 2021 02:09:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621987744; bh=RcYFFbYQ/nC3eUB902PZgO2rxyaeIEg3XxeLXE6R46Q=; h=From:To:Subject:Date:From; b=kVRPWdQH9EAoWaWstXuZ2t4CPEXg+wCo+VQtcYmrCMC9+CEhmj0hNb64PzOV7AGmI RUxaGoaoP+7Olu5/OCG/rBMrEFA7j/SRkWMx3Q+vmdu3Wfhfq4YzdyXwu8osT7G2Rp UvXZhUXrEh95M5acQpAc5LJHXrE6uKHLLh8sw7qw= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Wed, 26 May 2021 03:08:53 +0300 Message-Id: <20210526000855.17501-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.28.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] Fix Android camera HAL compilation on gcc 7 and 8 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This patch series fixes a compilation breakage of the camera HAL with gcc 7 and 8 (technically a link breakage with gcc 8), introduced by usage of the file system library. The first patch is a small refactoring, the second patch includes the real fix, details are included there. The compilation fix is a bit of a hack. If we need to use the file system library in more places (and I think we will), we should either drop support for gcc 7 completely, or abstract file system operations in helper classes. Any opinion ? Laurent Pinchart (2): android: camera_hal_config: Move include to .cpp file android: Fix file system library usage on gcc 7 and 8 meson.build | 8 ++++++++ src/android/camera_hal_config.cpp | 8 ++++++++ src/android/camera_hal_config.h | 1 - 3 files changed, 16 insertions(+), 1 deletion(-) Reviewed-by: Hirokazu Honda Reviewed-by: Jacopo Mondi Reviewed-by: Niklas Söderlund