From patchwork Fri May 21 13:28:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12340 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AF495C31FF for ; Fri, 21 May 2021 13:28:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 101946891D; Fri, 21 May 2021 15:28:35 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="g60Kv6q7"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F18368911 for ; Fri, 21 May 2021 15:28:33 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.162]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BD55C8D8; Fri, 21 May 2021 15:28:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621603712; bh=l8eSQCFCRHQm57NxBuqXkNCT/P6uObphUwD9YJc/S+w=; h=From:To:Cc:Subject:Date:From; b=g60Kv6q7qjdFpObzz0/6WxqFNYi+M2Fw++s8RdYdtZ4/ICtLn8NEh0hQjGFSqhHb/ gm7BduqEn9bjcnFley1HUC0eqHeTchRjYyWYjHFuEAPzTM6IEr2x1S+WKlMoMFlhlT pr2oHgp8F+cG/uTJYC+PNl723fSsX/bvyuVBskvY= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Fri, 21 May 2021 18:58:17 +0530 Message-Id: <20210521132823.322076-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/6] External IPU3 IPA Support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Changes in v3: - Drop 7/7 patch - decided to be done on top - Add a \todo about documenting IPA interfaces in [1/7] - Few style cleanups Changes in v2: - IPA Docs rework patch split (into 3) - Don't try to make a different 'internal' helper library - Drop relevant patch - Under discussion for now AND out of scope for this series. - Drop IPAConfigInfo documentation - Needs to happen during a follow up "doc" patch for entire ipu3.mojom adapted same as [PATCH 2/7] Umang Jain (6): ipa: Move core IPA interface documentation to a .cpp file ipa: mojom: Move CameraSensorInfo struct exclusively to IPA IPC ipa: ipc: Rename CameraSensorInfo to IPACameraSensorInfo ipa: meson: Install mojom generated headers to include paths ipa: ipu3: Introduce IPAConfigInfo in IPC meson: Add a configuration option to build IPAs Documentation/Doxyfile.in | 8 +- Documentation/guides/ipa.rst | 8 +- Documentation/meson.build | 1 + include/libcamera/internal/camera_sensor.h | 19 +- include/libcamera/ipa/core.mojom | 74 +----- include/libcamera/ipa/ipa_interface.h | 2 - include/libcamera/ipa/ipu3.mojom | 15 +- include/libcamera/ipa/meson.build | 8 +- include/libcamera/ipa/raspberrypi.mojom | 7 +- include/libcamera/ipa/rkisp1.mojom | 7 +- include/libcamera/ipa/vimc.mojom | 5 + meson.build | 1 + meson_options.txt | 5 + src/ipa/ipu3/ipu3.cpp | 14 +- src/ipa/ipu3/ipu3_agc.cpp | 2 +- src/ipa/meson.build | 5 +- src/ipa/raspberrypi/raspberrypi.cpp | 9 +- src/ipa/rkisp1/rkisp1.cpp | 6 +- src/libcamera/camera_sensor.cpp | 117 +-------- src/libcamera/ipa/core_ipa_interface.cpp | 237 ++++++++++++++++++ src/libcamera/ipa/meson.build | 5 + src/libcamera/meson.build | 1 + src/libcamera/pipeline/ipu3/ipu3.cpp | 14 +- .../pipeline/raspberrypi/raspberrypi.cpp | 4 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- 25 files changed, 332 insertions(+), 244 deletions(-) create mode 100644 src/libcamera/ipa/core_ipa_interface.cpp create mode 100644 src/libcamera/ipa/meson.build Reviewed-by: Laurent Pinchart