From patchwork Wed May 19 10:19:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12321 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3557EC31FB for ; Wed, 19 May 2021 10:20:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1FF1E68919; Wed, 19 May 2021 12:20:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bWjxIE7B"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 47083602B2 for ; Wed, 19 May 2021 12:20:04 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.105]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EFEA68DF; Wed, 19 May 2021 12:20:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621419603; bh=MUmNJiUk6bL/JN+4cGA35kps4wy4vFSbF1P75nkW8kE=; h=From:To:Cc:Subject:Date:From; b=bWjxIE7BDtSZh0y5CqFu8p+dIgBMUu8K78ncwOJxOzAVMCx4rTZIiGRE8ptcSOh8R fYXKD0oyTPuaeFCC3QKliOv/sPSxFcjc5X7q6BTro0UWLZ7YWGf0ERuFiGPFOqjCYd sYx+Fn5xMjusjYVGX2rHPMmQ9Ykq+t2Cyn4ZXOBg= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Wed, 19 May 2021 15:49:47 +0530 Message-Id: <20210519101954.77711-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/7] External IPU3 IPA support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Changes in v2: - IPA Docs rework patch split (into 3) - Don't try to make a different 'internal' helper library - Drop relevant patch - Under discussion for now AND out of scope for this series. - Drop IPAConfigInfo documentation - Needs to happen during a follow up "doc" patch for entire ipu3.mojom adapted same as [PATCH 2/7] Kieran Bingham (1): libcamera: pipeline: ipu3: Pass request metadata to IPA Umang Jain (6): ipa: Move core IPA interface documentation to a .cpp file ipa: mojom: Move CameraSensorInfo struct exclusively to IPA IPC ipa: ipc: Rename CameraSensorInfo to IPACameraSensorInfo ipa: meson: Install mojom generated headers to include paths ipa: ipu3: Introduce IPAConfigInfo in IPC meson: Add a configuration option to build IPAs Documentation/Doxyfile.in | 8 +- Documentation/guides/ipa.rst | 8 +- Documentation/meson.build | 1 + include/libcamera/internal/camera_sensor.h | 19 +- include/libcamera/ipa/core.mojom | 74 +----- include/libcamera/ipa/ipa_interface.h | 2 - include/libcamera/ipa/ipu3.mojom | 10 +- include/libcamera/ipa/meson.build | 8 +- include/libcamera/ipa/raspberrypi.mojom | 2 +- include/libcamera/ipa/rkisp1.mojom | 2 +- meson.build | 1 + meson_options.txt | 5 + src/ipa/ipu3/ipu3.cpp | 14 +- src/ipa/ipu3/ipu3_agc.cpp | 2 +- src/ipa/meson.build | 5 +- src/ipa/raspberrypi/raspberrypi.cpp | 9 +- src/ipa/rkisp1/rkisp1.cpp | 6 +- src/libcamera/camera_sensor.cpp | 117 +-------- src/libcamera/ipa/core_ipa_interface.cpp | 236 ++++++++++++++++++ src/libcamera/ipa/meson.build | 5 + src/libcamera/meson.build | 1 + src/libcamera/pipeline/ipu3/ipu3.cpp | 19 +- .../pipeline/raspberrypi/raspberrypi.cpp | 4 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- 24 files changed, 315 insertions(+), 245 deletions(-) create mode 100644 src/libcamera/ipa/core_ipa_interface.cpp create mode 100644 src/libcamera/ipa/meson.build Reviewed-by: Paul Elder Reviewed-by: Paul Elder Reviewed-by: Jean-Michel Hautbois Reviewed-by: Jean-Michel Hautbois Reviewed-by: Jean-Michel Hautbois