From patchwork Sat May 15 18:38:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12303 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 14E0EC31FB for ; Sat, 15 May 2021 18:38:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 602A06891D; Sat, 15 May 2021 20:38:41 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="R4vWfzbF"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C18696891A for ; Sat, 15 May 2021 20:38:39 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C8FB436; Sat, 15 May 2021 20:38:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621103919; bh=42aF5ArH59GAbxbkluixWl1xbL234e8A/+Su7nFLGE4=; h=From:To:Cc:Subject:Date:From; b=R4vWfzbF1qF1+rXiTe4cV/lyjnW8e+kEmVSm4GtW04gvyKcjbWabcPwME8V3MaebB /T17/LcJorUTo9c2y0bAG3ui5T84QF7+U+AVrmgB06YWYOwUipnDG1+YSeP5rNAtvG UfP4lhvq/57SSmZ1EFb3cfy/INzNUbsQ/NaMIg8M= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sat, 15 May 2021 21:38:22 +0300 Message-Id: <20210515183826.21003-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.28.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/4] android: camera_metadata: Miscellaneous improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, These small improvements stem from the review of the CameraMetadata dynamic allocations series. As the series has been merged already, it was as fast to express the review comments as code as it would have been to write them in English. The patches haven't been tested. Paul, would you be able to test them ? Laurent Pinchart (4): android: camera_metadata: Rename sizeofT argument to elementSize android: camera_metadata: Constify argument to addEntry() and updateEntry() android: camera_metadata: Make internal functions private android: camera_metadata: Add type sanity check to updateEntry() src/android/camera_metadata.cpp | 15 ++++++++++++--- src/android/camera_metadata.h | 22 +++++++++++++++------- 2 files changed, 27 insertions(+), 10 deletions(-) Reviewed-by: Paul Elder Tested-by: Paul Elder