From patchwork Mon May 10 09:58:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12233 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D4E59BF829 for ; Mon, 10 May 2021 09:59:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 301B868918; Mon, 10 May 2021 11:59:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="YctkrrV7"; dkim-atps=neutral Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C5F6C6890C for ; Mon, 10 May 2021 11:59:05 +0200 (CEST) Received: by mail-wm1-x332.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso9362380wmc.1 for ; Mon, 10 May 2021 02:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Vj7Fotv2LsXW2UTlcbNv8AXStZrYNWCXx+RiUpq6wPw=; b=YctkrrV7ZK8iPly2ARtOqSSUzfbc/Dki2djUCX8kZfiodLXfpXUMq0bduxoOpYuT4Q LY7aHkh2h2YcwQypI9PgmxcDQY5eeHsCdI/RzKBHsuv5GMkjeRk8M60GcTCula0XT7Mf bpRuThcbL7weLfPr7yzn8JRYw24tUK56HBX6Ow1OBmAwsmh17u9+TJ90Jv4BUfapQkhd 9iHKwT6ZDQAcgwAHSGOK43IdWkhNBAjf3dX0gjpTOhz88N5AxUJ1uTWCl7XK7WvimQkX wUfOBwWMLkPP7MdLHJyzVraqXHogBznkj+kqNk73D1TRzB8IDcYEgtghZWcV0K5nOo8Y NxCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Vj7Fotv2LsXW2UTlcbNv8AXStZrYNWCXx+RiUpq6wPw=; b=JlQChUfzzG6MiS5LBE6+NyLzQjgX3QbiScUaM4nrCiIVaHHhbTb6HolA5r9OSgR2h8 WG68XeEHRR/rUx5FmRZc3WarsOWsjA7a5I1FJM+17YlF8udgA/jzVohAM468fcSeg7Xj CVbTrMlh0UOuvsyx4JuxgapZ9YnNLWegZ8MqWjalKOB4J6md/owDiJ9DOeoi5sR5YZOi XzoilEj0hO6ozb0Ykk85qTcwOO+MW774WsLBIumGNDh4Lk6+D366HtkbHQfn3+R452FD E7IurEfEXNA8ZvSfYv5R95gwR0XSc93b5YU6QRyJ8DlEXMVyOEbJIHVGjTOCFfR5cJtT exWA== X-Gm-Message-State: AOAM531M8JI8cREMskH0+6/lJNRZyU4NZYx9kux4VntknwYOvGw7UxcX qRHHbMI8nqrQBgmmV5gwe/VrbXdqaqwt1g== X-Google-Smtp-Source: ABdhPJx6zyLyZGkyjwf9nKly6+ifg3fafAcxSCCHDESdJfsOz0HDs7wJ+BZmG2n9HUsOwrdZVfzjcA== X-Received: by 2002:a7b:c1da:: with SMTP id a26mr24628439wmj.40.1620640745145; Mon, 10 May 2021 02:59:05 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:e710:3ec:6dad:dc2]) by smtp.gmail.com with ESMTPSA id y17sm24767917wrw.90.2021.05.10.02.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 02:59:04 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 10 May 2021 10:58:09 +0100 Message-Id: <20210510095814.3732400-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 0/6] ipa: raspberrypi: Rate-limit the controller algorithms X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Version 6 of this patch series introduces the following changes: 1) Switch from RPiController::Metadata::Overwrite() back to RPiController::Metadata::Merge(). This simplifies the logic in the IPA. 2) Introduce a new change in patch 3/6. This replaces our use of std::lock_guard with std::scoped_lock to mitigate deadlock when locking multiple mutexes. 3) SensorTimestamp is no longer a draft control. David, I have removed your R-b tag from 6/6 because of the scope of change. When you get a chance, could you re-review please? Thanks, Naush Naushir Patuck (6): ipa: raspberrypi: Store dropped frame count in a member variable ipa: raspberrypi: Reformat RPiController::Metadata class header ipa: raspberrypi: Switch to std::scoped_lock in the Metadata class ipa: raspberrypi: Add move/copy ctors and operators to Metadata class ipa: raspberrypi: Add a Merge method to RPiController::Metadata ipa: raspberrypi: Rate-limit the controller algorithms src/ipa/raspberrypi/controller/metadata.hpp | 61 +++++++++++++++---- src/ipa/raspberrypi/raspberrypi.cpp | 56 ++++++++++++++--- .../pipeline/raspberrypi/raspberrypi.cpp | 5 ++ 3 files changed, 100 insertions(+), 22 deletions(-)