From patchwork Fri May 7 11:37:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 12228 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8C693BF831 for ; Fri, 7 May 2021 11:37:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C2ACD68919; Fri, 7 May 2021 13:37:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="abNw05tR"; dkim-atps=neutral Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F06E1602BB for ; Fri, 7 May 2021 13:37:31 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id t18so8888877wry.1 for ; Fri, 07 May 2021 04:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GX00/Bh+Qjes4x1bQzvxWZDimTqTS0/k/0kz+ZbCzCo=; b=abNw05tRx39cVVjnUqyE6kMZjUzOtyt9BQuXIub9zD5pffH/wt4moUQArzTYeIHnWL t2PHuoHYBt1KiFbiCLN5h12utBoxhF4Nf42sI9Q5TfRg6bWAp508em/SiWMPcPYHmGpG 0f2m5UfYs4od84nbCgBIg77jtZ8eI77PUVxGUqaln3sY06dbLaVq7Xvi1CLW7ULj1YOU ZC+0H1EYh6ubyzuePnWEM+70SlTDQrU4zUpmJ+SSZAdCPaJDPynyBwDD2GbEcYO+MDtw CQs9zqopDgdn/gKMUg02mXxchtv/Z0PZQ7ot2dXKoPRdRdnWApxjSUprFSp7j4Gn7rVk SKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GX00/Bh+Qjes4x1bQzvxWZDimTqTS0/k/0kz+ZbCzCo=; b=YrCPVbF8YM0XYF0Jc0cPyL5dJc38TscTMoBI/NEBjTzgNatLD9tsKarAEfe/yskom6 0g2bf0ABA8dbqIiQB58ea08KLtrv5TtAIg25BRSUN1pxRRb9h4cy0/mtDEpBAELePuJt ee8NSu4oeuG8grpOomtC//CXUQSNyx95Y+8kYGN5XbfMBxIdagKuB+ag2lpbB8TGQdsk Ren0cuoZV9JL95rUcPGpKa5z6KvpvkUFVr8IyBn1ytDE6PIn7oxdzxZFfJ8rjbvqMh0M A+9jhnF/zVFzIoqXZvbaRYsM0DzJ1d1jieYeGKk6N1lmN7Ak8r1n2izMi1bFdQgAAoYv lWqw== X-Gm-Message-State: AOAM530xBMMI0hKSHQAk6aYzaV3i/RsZiCsC7K2K0LsoabKSM4oXvVbc IM1bJqlgglJ7hcYubZnR/1IbqoM/ANqZAA== X-Google-Smtp-Source: ABdhPJyODePko3056dAjx6jcngiHrPlH6mz7lBL0RS3nO/rEor6bntycpx8ex1pE4pxPhxa9qYDcgw== X-Received: by 2002:a5d:638f:: with SMTP id p15mr11792725wru.255.1620387451390; Fri, 07 May 2021 04:37:31 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id w22sm13739009wmc.13.2021.05.07.04.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 04:37:30 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Fri, 7 May 2021 12:37:26 +0100 Message-Id: <20210507113728.14037-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/2] Raspberry Pi generalised sensor metadata parsing X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Thanks for the various comments. Version 4 of the set is not functionally different, but contains some tidy-ups suggested by Marvin. I've also added a precursor patch which, as suggested, switches our MdParser class to take a Span as its input buffer. Again, I think this is slightly tidier now that Spans exist. Thanks and best regards David David Plowman (2): ipa: raspberrypi: Make sensor embedded data parser use Span class ipa: raspberrypi: Use CamHelpers to generalise sensor embedded data parsing src/ipa/raspberrypi/cam_helper.cpp | 54 +++++++++++++++ src/ipa/raspberrypi/cam_helper.hpp | 11 +++- src/ipa/raspberrypi/cam_helper_imx219.cpp | 8 +-- src/ipa/raspberrypi/cam_helper_imx477.cpp | 8 +-- src/ipa/raspberrypi/md_parser.cpp | 23 +++---- src/ipa/raspberrypi/md_parser.hpp | 20 +++--- src/ipa/raspberrypi/raspberrypi.cpp | 80 ++++++++--------------- 7 files changed, 118 insertions(+), 86 deletions(-)