From patchwork Fri May 7 02:17:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 12217 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BCD0DBF831 for ; Fri, 7 May 2021 02:17:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 182C7602BD; Fri, 7 May 2021 04:17:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="DEClPX7G"; dkim-atps=neutral Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 188CD602BA for ; Fri, 7 May 2021 04:17:35 +0200 (CEST) Received: by mail-pf1-x42f.google.com with SMTP id c17so6563453pfn.6 for ; Thu, 06 May 2021 19:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YtYD8qMWxPDfXBFuhGlgfvDEwJMtTGR/T1IwULmvSTw=; b=DEClPX7GmZAymyMfN6PMXGIg14a5Nfg4WEikdp9Z4rfVE5+DPpl7bUS4BxqNUovEq/ h0v6P724nd6+J5w5WZdgyOKUTFxoyCj24kK2CYoJC8dLl1QBIuewu0K1V73DIzqvsRMY dc3ZJvgaDrHxpJCjnrCNRs0oIcFELOnjdzLYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YtYD8qMWxPDfXBFuhGlgfvDEwJMtTGR/T1IwULmvSTw=; b=QvObVdngrzbBzzr2To7fAAHJd64WkcmCKPq57PbpMNWtI8aVMthcjrWHFoYGdLVza5 25PyM317W4lLhB/WqWDRS0gICai8DagjPuPZuO65DMm+EA2ZESHtSiopHgKORhB5AvDY urhaPJX6iFwCGlrBPSsN9+FK1ImAsDwIYquYmLihkVaxAniHZ4NToRR6Kb+tYkeg+JLe ZxIzsGtrPC7j/b1vAVI2y1k6DXw4V57dEMhckuD7L39eQv5qpSDxC9St6gVPvGxmG7dv vd5uhvPv9cpPff7ph92COFmwf+lEkgvpHwVcQSb+979BEHqQaJtS3JU9hTaftVLBfz8R EsvA== X-Gm-Message-State: AOAM530BDo8TaXU0svyRHFeRvLE2J88MVxz4knm0alxkjh5wFEF8oz77 zRNVWMEfxex2zGqHPqiB6t8grHM6LRsDSw== X-Google-Smtp-Source: ABdhPJyoNgP0qZeDy22+rQpvO6bdMC1rj7VDnj0tJAYJl1rH2y95tqNSikNRaRUjxFXNNYl3ZSHy+A== X-Received: by 2002:a63:1064:: with SMTP id 36mr7514717pgq.164.1620353853360; Thu, 06 May 2021 19:17:33 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:2f2e:9aad:9133:6283]) by smtp.gmail.com with ESMTPSA id a190sm3299542pfb.185.2021.05.06.19.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 19:17:32 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Fri, 7 May 2021 11:17:25 +0900 Message-Id: <20210507021727.1848611-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] Remove V4L2Control classes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" V4l2ControlId and V4L2ControlInfo has no additional member variables or functions to ControlId and ControlInfo, and just convenient classes to create ControlId and ControlInfo with v4l2_query_ext_control. Therefore, they are unnecessary and rather just introduce confusion. This patch series removes them. Hirokazu Honda (2): libcamera: pipeline: Remove unnecessary v4l2_controls.h includes libcamera: V4L2Control: remove V4L2Control classes include/libcamera/internal/meson.build | 1 - include/libcamera/internal/v4l2_controls.h | 31 ---- include/libcamera/internal/v4l2_device.h | 4 +- src/libcamera/meson.build | 1 - src/libcamera/pipeline/ipu3/ipu3.cpp | 1 - .../pipeline/raspberrypi/raspberrypi.cpp | 1 - src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 1 - src/libcamera/pipeline/vimc/vimc.cpp | 1 - src/libcamera/v4l2_controls.cpp | 151 ------------------ src/libcamera/v4l2_device.cpp | 72 ++++++++- 10 files changed, 71 insertions(+), 193 deletions(-) delete mode 100644 include/libcamera/internal/v4l2_controls.h delete mode 100644 src/libcamera/v4l2_controls.cpp Reviewed-by: Jacopo Mondi --- 2.31.1.607.g51e8a6a459-goog