From patchwork Mon May 3 09:26:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 12161 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0CB68BDE78 for ; Mon, 3 May 2021 09:26:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 13C5A6891C; Mon, 3 May 2021 11:26:26 +0200 (CEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9ED01602C0 for ; Mon, 3 May 2021 11:26:24 +0200 (CEST) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 57B4BE0003 for ; Mon, 3 May 2021 09:26:24 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 3 May 2021 11:26:58 +0200 Message-Id: <20210503092705.15562-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/7] ipu3: imgu: Improve ImgU calculation procedure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" To the ImgU pipeline calculation. To recap: the current ImgU calculation procedure doesn't work if we select a sensor resolution smaller than the full frame size, and result in a stall in the ImgU producing frames, or in an error in finding any configuration at all. This set of improvements fixes some of the issues we had. In example, on Soraka $ cam -swidth=1280,height=720 -swidth=640,height=480 -c1 -C now works with a 2112x1188 frame input. As the ImgU is not been validated with 320x240 resolutions, some use cases like main=1920x1080,vf=320x240 remain broken and commit 7208e70211a6 ("libcamera: ipu3: Always use sensor full frame size") cannot be yet reverted. The series remains of awful quality, I just collected tags and applied a few comments here and there and re-tested with CTS. I've dropped the controversial "libcamera: ipu3: imgu: Change IF_CROP_MAX to 40" as the issue is not clarified. I've opened a new issue on the Python script to replicate one of the comments received by Laurent on v1 https://github.com/intel/intel-ipu3-pipecfg/issues/2 and referenced it in code. Overall, the final result is not worse than how the ImgU configuration procedure looked like before, it might fixes some bugs, but nobody is really happy with the result :( No regressions detected when running CTS. Jacopo Mondi (7): libcamera: ipu3: imgu: Update BDS calculation process libcamera: ipu3: imgu: Filter BDS by height libcamera: ipu3: imgu: Fix BDS height calculation libcamera: ipu3: imgu: Fix IF height selection libcamera: ipu3: imgu: Fix BSD height size comparison libcamera: ipu3: imgu: Add pipe calculation debug libcamera: ipu3: imgu: Bump script version src/libcamera/pipeline/ipu3/imgu.cpp | 111 +++++++++++++++++++++------ 1 file changed, 89 insertions(+), 22 deletions(-) --- 2.31.1