From patchwork Tue Jan 1 21:29:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 121 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DE4CF60B31 for ; Tue, 1 Jan 2019 22:29:51 +0100 (CET) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F26A505; Tue, 1 Jan 2019 22:29:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1546378191; bh=sXdRvE+rjsw5wy9Rn2NH4Yg8T0PjKTCjzION6MD6RAI=; h=From:To:Cc:Subject:Date:From; b=vbDHezIsnohlP5PEs/TumvyvONeKBOG1dDX5qu+n357tV39wcoi/p1Eh3wmUvfQ4l dUyUFw2kCCmAhMz0NgcVs9y/OJXOzn+2+LqHSmlmejhY+63SFudwwqVLRsvvjS0+RC VY0IuPOgvCHDJL+ULQP7N1P/tYjyHg3iveKqpt/s= From: Kieran Bingham To: LibCamera Devel Date: Tue, 1 Jan 2019 21:29:42 +0000 Message-Id: <20190101212947.28098-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/5] test: Unit Test Improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jan 2019 21:29:52 -0000 A cleanup and refresh now that more patches have been integrated. Firstly, fix the location of the test definition for the media_device, then provide a refreshed implementation of the "test: Use foreach iterators to simplify definitions" patch. With this change added, the definitions for the test includes somewhat clutter the base test/meson.build and it seems appropriate that they live as part of the libtest definitions - so move them there accordingly. Then update the media_device suite meson.build to use the foreach syntax to allow for the unit tests to be extended here. Finally, with actual classes implemented in the library there is no further need for the early 'init' test and fake library implementation, and so this is removed and cleaned up. Kieran Bingham (4): test: media_device: Move test definition test: Use foreach iterators to simplify definitions test: Move include definitions to libtest test: media_device: Convert to foreach Laurent Pinchart (1): libcamera: Remove libcamera class include/libcamera/libcamera.h | 10 ---------- src/libcamera/main.cpp | 19 ------------------- src/libcamera/meson.build | 1 - test/init.cpp | 16 ---------------- test/libtest/meson.build | 12 ++++++++++++ test/media_device/meson.build | 14 +++++++++++--- test/meson.build | 33 ++++++++++++++++----------------- 7 files changed, 39 insertions(+), 66 deletions(-) delete mode 100644 src/libcamera/main.cpp delete mode 100644 test/init.cpp