From patchwork Fri Apr 23 10:47:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 12098 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3D6F6BDB15 for ; Fri, 23 Apr 2021 10:47:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9653768878; Fri, 23 Apr 2021 12:47:21 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RLdvI4L5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D5DB4602D1 for ; Fri, 23 Apr 2021 12:47:20 +0200 (CEST) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 310D2332; Fri, 23 Apr 2021 12:47:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619174840; bh=yb4E8v6VzOp2BjWWIKnrk+k0Obyaa4VhuHuTevK2Xqs=; h=From:To:Cc:Subject:Date:From; b=RLdvI4L5mM3Ep89Q7uzZ5/TvlQ5v7dr4nd0ScANgmlZQO34q1/syAh3+Il2v5mHSp Uda97OfM8DLLsMN3NfCO/P6RFaR5dDlYMkhuD9AjiP2zGjeenYAaD8DPle+jpsYi0D 9TbTvXqnXBZ8yffXZt6SZPdmrFfjAEsrhKKQ60Po= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Fri, 23 Apr 2021 19:47:08 +0900 Message-Id: <20210423104711.401547-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/3] Fix support for core.mojom structs X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series fixes support for structs defined in core.mojom with skipHeader only. Previously these structs were only supported (tested) for use in custom function parameters, but not as members of other structs. This patch series fixed that. In v3, we add a libcamera namespace to core.mojom. This means that whenever core.mojom structs are used in other mojom files, they need to be specified with the namespace, eg: struct A { libcamera.ControlList list; }; Patch 3 makes this change. Patch 2 enables obtaining the proper namespace of the origin of the struct. Paul Elder (3): utils: ipc: Include instead of forward-declare CameraSensorInfo utils: ipc: Use the proper namespace for mojom structs ipa: mojom: Put core.mojom in the libcamera namespace include/libcamera/ipa/core.mojom | 5 +-- include/libcamera/ipa/ipa_interface.h | 6 ++-- include/libcamera/ipa/ipu3.mojom | 11 +++--- include/libcamera/ipa/raspberrypi.mojom | 29 ++++++++-------- include/libcamera/ipa/rkisp1.mojom | 13 +++---- include/libcamera/ipa/vimc.mojom | 2 +- .../module_ipa_serializer.h.tmpl | 2 +- .../libcamera_templates/serializer.tmpl | 34 +++++++++---------- .../generators/mojom_libcamera_generator.py | 16 ++++++--- 9 files changed, 65 insertions(+), 53 deletions(-)