From patchwork Mon Apr 19 13:14:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 11982 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8D605BD814 for ; Mon, 19 Apr 2021 13:14:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 23AC168832; Mon, 19 Apr 2021 15:14:18 +0200 (CEST) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D5A90602CD for ; Mon, 19 Apr 2021 15:14:16 +0200 (CEST) Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 661CC10000A; Mon, 19 Apr 2021 13:14:16 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 19 Apr 2021 15:14:20 +0200 Message-Id: <20210419131433.22920-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, v2 grow quite significatively compared to v1 :/ Reason is that now all the pipeline handlers report SensorTimestamp, each one with its own specificities. Here and there a few drive-by fixes, and two patches for cam to add support for listing all the metadata associated with a completed Request. v1->v2: - controls: Refer to CLOCK_BOOTTIME explicitely - pipeline: - Add support for SensorTimestamp in all pipelines - HAL - Assume SensorTimestamp is always available. In future, it might be beneficial to add to lc-compliance a test to make sure SensorTimestamp is reported. Maybe a 'mandatory' flag can be added to the controls definition for that purpose. Thanks j Jacopo Mondi (13): libcamera: controls: Destage 'SensorTimestamp' libcamera: ipu3: Report sensor timestamp libcamera: uvc: Report sensor timestamp libcamera: rkisp1: Do not over-write metadata libcamera: rkisp1: Report sensor timestamp libcamera: simple: Report sensor timestamp libcamera: vimc: Report sensor timestamp libcamera: buffer: Re-work setRequest() documentation libcamera: raspberrypi: Do not over-write metadata libcamera: raspberry: Report sensor timestamp cam: Add option to print the Request metadata cam: Implement OptMetadata android: camera_device: Use controls::SensorTimestamp src/android/camera_device.cpp | 19 +++++----------- src/android/camera_device.h | 3 +-- src/cam/capture.cpp | 15 ++++++++++++- src/cam/capture.h | 1 + src/cam/main.cpp | 3 +++ src/cam/main.h | 1 + src/libcamera/buffer.cpp | 11 ++++++++-- src/libcamera/control_ids.yaml | 21 ++++++++++++------ src/libcamera/pipeline/ipu3/ipu3.cpp | 9 ++++++++ .../pipeline/raspberrypi/raspberrypi.cpp | 22 +++++++++++++++++-- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 ++++++++++- src/libcamera/pipeline/simple/simple.cpp | 11 ++++++++++ src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++ src/libcamera/pipeline/vimc/vimc.cpp | 4 ++++ 14 files changed, 108 insertions(+), 28 deletions(-) --- 2.31.1