From patchwork Thu Apr 15 13:52:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 11949 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B7FF1BD22F for ; Thu, 15 Apr 2021 13:51:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7DD0B68814; Thu, 15 Apr 2021 15:51:39 +0200 (CEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AE7EF605AE for ; Thu, 15 Apr 2021 15:51:37 +0200 (CEST) Received: from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) (Authenticated sender: jacopo@jmondi.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 6E50E240011 for ; Thu, 15 Apr 2021 13:51:37 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Thu, 15 Apr 2021 15:52:08 +0200 Message-Id: <20210415135213.94511-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 0/5] android: Introduce HAL configuration file X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A new iteration to address Laurent's and Kieran's comments: - Configuration: - call open() (now parseConfigurationFile()) at construction time - s/Fatal/Error - search configuration file only in sysconfdir - s/CameraProps/CameraConfigData/ - s/valid/isValid() - Integration - Take Laurent's suggestion in in camera_hal_manager.cpp - Drop default = nullptr in CameraDevice::initialize() === I have not run this version === (I'm physically away from Soraka today) The only thing that can fail compared to previous version is the path lookup. I'm sending it out anyway, mostly to comment on patch 6/6... will follow up there... Thanks j Jacopo Mondi (4): libcamera: List dependency for Android Camera3 HAL android: Add CameraHalConfig class android: camera_device: Get properties from configuration android: soraka: Add camera HAL configuration Kieran Bingham (1): src: meson: Define system paths README.rst | 3 + src/android/camera_device.cpp | 56 +++- src/android/camera_device.h | 3 +- src/android/camera_hal_config.cpp | 400 ++++++++++++++++++++++++ src/android/camera_hal_config.h | 40 +++ src/android/camera_hal_manager.cpp | 33 +- src/android/camera_hal_manager.h | 3 + src/android/data/soraka/camera_hal.yaml | 8 + src/android/meson.build | 2 + src/ipa/meson.build | 17 +- src/meson.build | 9 + 11 files changed, 557 insertions(+), 17 deletions(-) create mode 100644 src/android/camera_hal_config.cpp create mode 100644 src/android/camera_hal_config.h create mode 100644 src/android/data/soraka/camera_hal.yaml --- 2.31.1