From patchwork Wed Apr 14 10:29:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 11926 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F1F36BD224 for ; Wed, 14 Apr 2021 10:30:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 364A36880B; Wed, 14 Apr 2021 12:30:02 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="am3mO3lw"; dkim-atps=neutral Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EE0568803 for ; Wed, 14 Apr 2021 12:30:00 +0200 (CEST) Received: by mail-ej1-x635.google.com with SMTP id n2so30592937ejy.7 for ; Wed, 14 Apr 2021 03:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=t9vWcsXaDBd3+sJ1B9bDg8ap1BT9h6srAKC/rPzkLGw=; b=am3mO3lwZrId0MBmyEhkqs61vQtc5WW1wPmkjzybLTFB4BqltTsJuFFBqYPmlJf6SR kbWjBuiMNGKmIdBPGCFMH8lM3ByHtpyw2m3HAXAlN1TWmLRqSa13BhN2YZCT8qWGx4C6 oocXGrYZUZ0YfETtH5Y1FXv9ScWLcKWDDY3Li47+1QzmjWNuBvJNao8XeKVDQDqby1w3 vYxMtQw53rr8CkLdQemreGX+wNssXKgnqvqRuRXWtidUrKwboCXOQq/kAoUApOlHKwro xFUghZKrNXMPlQEeHFE9AL8TwwkdouJBndNUWilyqrJDFZlRsU64m89hWH/WcDpuiBJy YuVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=t9vWcsXaDBd3+sJ1B9bDg8ap1BT9h6srAKC/rPzkLGw=; b=Zvx++/xHrc25ayQsvd5A6I+SohIFlkNy1KFjpfXiCNAgCKlkeujkoN1Ko6O1eHd3HF jfisa3c2SZOBYbkRrpYhXvvPO7UXRKOlGe/9/tljlu2rbc1bCAkIx1KWO2chaK+m43Vw gQBgbs9JC0yNYg+gSEoJxSCy5+GRLTa4h4enZzD7yIHHRifwf9YxtTfLE4LSiEjaoS7G 8BtHUd70cJa4pRidY1aRyVrUpnsNtWg8Wl5cT8InJfn24Tpu3Mn+pWcn0+st1+09zPNx CimevbaIMs55CiWUtoFLv0qZf1Ufb3nwm+gmQp7VOmNOWQapUZGKH6zZHh1GTgUq3ZrH m3zg== X-Gm-Message-State: AOAM532WNcu+cAD0OFEHzULRfeRIW4NpG18vxqyC4cLZ93y4dpLgHcOH Xz3pC1drTFTI4pIcBxiG+hg5G5IiJZZVbg== X-Google-Smtp-Source: ABdhPJySEVmTSgkgJnuIDc06G0RGQzdkAiF9KDYf1sCLTRO958ETIjJgnyzQngzg5L1vrD8ig1SMwg== X-Received: by 2002:a17:906:9ac5:: with SMTP id ah5mr11318850ejc.360.1618396199405; Wed, 14 Apr 2021 03:29:59 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id h8sm11369137ede.25.2021.04.14.03.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 03:29:58 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Wed, 14 Apr 2021 11:29:52 +0100 Message-Id: <20210414102955.9503-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/3] Raspberry Pi: handle sensors more flexibly X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone This patch set is essentially identical to the previous v2 version, except that the ASSERT in the ColourGainCode method has been replaced by a more helpful LOG(..., Fatal), as per the suggestions I received. I've tried to include all the right "Reviewed-by" tags too. Thanks and best regards David David Plowman (3): ipa: raspberrypi: Make CamHelper exposure methods virtual ipa: raspberrypi: Add CamHelper::ColourGainCode method ipa: raspberrypi: Update sensor's RED/BLUE balance controls when present include/libcamera/ipa/raspberrypi.mojom | 1 + src/ipa/raspberrypi/cam_helper.cpp | 18 ++++++++++++++++++ src/ipa/raspberrypi/cam_helper.hpp | 8 +++++--- src/ipa/raspberrypi/raspberrypi.cpp | 13 +++++++++++++ .../pipeline/raspberrypi/raspberrypi.cpp | 10 ++++++++++ 5 files changed, 47 insertions(+), 3 deletions(-)