From patchwork Thu Apr 8 13:36:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 11870 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1286DBD16B for ; Thu, 8 Apr 2021 13:36:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 491BF687F2; Thu, 8 Apr 2021 15:36:41 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="UIa8hB5D"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D8ED2602CC for ; Thu, 8 Apr 2021 15:36:39 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id k128so1219252wmk.4 for ; Thu, 08 Apr 2021 06:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YqlsPugM4Bo2HsfxSDoSDpSKVRkLjq/+BLsjMFvuxoU=; b=UIa8hB5D+C53fIMYefafZ2eKIGGK+JQRzH4SKLKmDsxvIHJUkeczgImaTv2lrQ9C1J 22GSzNWDO24g3AEFSJMfssEeWta/f+F8lxB+NActMSFxnOgua/Nh/Tc9jmrO8V5KTzSa ZMh8bwp0ZcY7DBsRzQkhj78A9MS8hysW0JBaNX7MYiHOOlap6NywitKgW8WYZpe9JAVf bupOsRKqAUDwFeEJhhOOv7uksFI8mbCIEvVynhIVm2zVltUCJ03EHEW0zcLfaaWopZRs wWx1LQsOieQ+gc5ePXMLzH4hJqFZY2ibQuP4aVlsN+ga+fDk6eAgHC92Fzgsk0oAWxPg HE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YqlsPugM4Bo2HsfxSDoSDpSKVRkLjq/+BLsjMFvuxoU=; b=KpiYjAnxBnZ05iLfkHQZ9QG0ezoYE25iWYAQ2Z/Zb0cAPkhGih2R/M/KQmxOpVXnZV iVoXIxP2mYO5Ny2HiCmhxrSFgOb+/BC/IwnqPd9qfulZlGFrGaXw3o9unwJngetFzUfi gr90yLbXMqnZp+QygLBc0G3+JIWilOmfyE00ZYdxzc2VbWLpDMRvj5QyS75rqSwBCSS+ 254nbjH2yY3oMZvGGDcqEqS7JH7pdsT3NBO0TK0svz5AwExsQUaqTKkdvp2vtjK4WYZ2 aTqqlkc8ScnYridWvTztiFpaVA2GO49vYRuKYfIHoOiAkrWBHwhQu5AhjIaa/HB0dve0 Id+Q== X-Gm-Message-State: AOAM531RZLpZhcu1VHwF0m+V8x1NZ2DqpyQZS/sPBXM/9Y7kV0UGhArG EQ5VhVj8usUVovdn6fNOtRetDNq4nLRLkg== X-Google-Smtp-Source: ABdhPJz3s7/DtcyPeIM3sxsQzrJVxO3S+UuNf0jTzZfLMcHznAWZEIzH759UUrn7T6i2jjnDI9GsSw== X-Received: by 2002:a05:600c:219a:: with SMTP id e26mr2301224wme.64.1617888999260; Thu, 08 Apr 2021 06:36:39 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id z18sm13132522wmc.27.2021.04.08.06.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 06:36:38 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 8 Apr 2021 14:36:31 +0100 Message-Id: <20210408133634.16815-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/3] Raspberry Pi: handle sensors more flexibly X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Here's a second version of this patch set. I've made some improvements in the light of Naush's feedback, outlined below. 1. There's a new second patch that adds a CamHelper::ColourGainCode method. 2. The final patch adds a new "setSensorControls" signal to the IPA, so the RED/BLUE balances don't have to be signalled back using the DelayedControls mechanism. Hope that makes sense! Thanks David David Plowman (3): ipa: raspberrypi: Make CamHelper exposure methods virtual ipa: raspberrypi: Add CamHelper::ColourGainCode method ipa: raspberrypi: Update sensor's RED/BLUE balance controls when present include/libcamera/ipa/raspberrypi.mojom | 1 + src/ipa/raspberrypi/cam_helper.cpp | 11 +++++++++++ src/ipa/raspberrypi/cam_helper.hpp | 8 +++++--- src/ipa/raspberrypi/raspberrypi.cpp | 13 +++++++++++++ src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 10 ++++++++++ 5 files changed, 40 insertions(+), 3 deletions(-)