From patchwork Thu Apr 1 10:13:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11806 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2DE3AC0DA4 for ; Thu, 1 Apr 2021 10:13:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9E4DF6877D; Thu, 1 Apr 2021 12:13:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Ys31gcFa"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A95596877C for ; Thu, 1 Apr 2021 12:13:53 +0200 (CEST) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E5D45F7; Thu, 1 Apr 2021 12:13:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1617272033; bh=sd3odnMapND1kR31xHqwUQ1f9t11ERbH2NkjPB/mFqU=; h=From:To:Cc:Subject:Date:From; b=Ys31gcFa+cg5UkW6Ea5HyLfrUiaB3glWoCOJfCsJ0Hf/AknmMZn1vOCQrDjbLv+7q 7ycNBywRDss9bL/irhg1Bbk6dqkyaf6AXMOHg2wCbiSOqH3NYz1F9tRXHba663TIEJ +DSTQOV/1vutZ8wxoMT48NYIy7rll0WQkm2aZ6ak= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Thu, 1 Apr 2021 19:13:32 +0900 Message-Id: <20210401101340.160590-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 0/8] android: First set of FULL fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patchset switches to hardware level FULL, and is the first set of fixes for the resulting CTS test failures. The tests that this patchset fixes are: - android.hardware.camera2.cts.CameraDeviceTest#testCameraDevicePreviewTemplate - android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceRecordingTemplate - android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceStillTemplate - android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl - android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControlFastFps - android.hardware.camera2.cts.CaptureRequestTest#testAeModeAndLock - android.hardware.camera2.cts.CaptureRequestTest#testAwbModeAndLock - android.hardware.camera2.cts.CaptureRequestTest#testFlashControl The biggest debate that we have is on testNoiseReductionModeControl, about what frame duration to report, if any. Also I think it's about time to start laying down some plumbing for capabilities and controls to and from the pipeline handler, and not just setting values to satisfy CTS. But I think this is a start. Paul Elder (8): android: Switch to FULL android: CameraDevice: Report proper min and max frame durations android: camera_device: Add separate template for still capture android: camera_device: Set proper frame duration android: camera_device: Set noise reduction values for FULL requirements android: camera_device: Add AE mode off to AE available modes android: camera_device: Add AWB mode off to available AWB modes android: camera_device: Fix exposure time range and max analog sensitivity src/android/camera_device.cpp | 82 ++++++++++++++++++++++++++++------- src/android/camera_device.h | 3 ++ 2 files changed, 70 insertions(+), 15 deletions(-)