From patchwork Tue Mar 30 21:12:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 11798 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DD193C0DA3 for ; Tue, 30 Mar 2021 21:12:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0C0FF68781; Tue, 30 Mar 2021 23:12:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ajx1XHZ0"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C8D61602D2 for ; Tue, 30 Mar 2021 23:12:14 +0200 (CEST) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:40dc:d947:395c:88d2]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 672A7102; Tue, 30 Mar 2021 23:12:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1617138734; bh=ZQpe/L5AOlgBUd7ZEDA+kuxj+Q3Pfkl1ucsO4ubMu6w=; h=From:To:Cc:Subject:Date:From; b=ajx1XHZ0trjF7Ipty5DCmOg1J0KADzVmWlb2oDMD5cxbfY5GQzBhl4KgonKX3vBil snnSCSyEjby9Gz0P4we04p+M7AA6r8NtOT/aoCWfPkmR1P0minpOP6QXBkNq0zK9cP SekLjZfRsCh6a+NC3LXUEW/jx/qNyMu/eqz+E9vY= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Mar 2021 23:12:06 +0200 Message-Id: <20210330211210.194806-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/4] Implement IPA algorithms and demo with IPU3 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Here is v4 of the IPA demonstration on IPU3. It demonstrates a conjunction of automatic exposure (AGC) and automatic white balance (AWB). The skeleton are extracted from RPi controller and probably subject to modifications and discussions : - are the mandatory methods really those ? - how to exchange data between algorithms ? - metadata like RPi? - IPC ? - public methods? - controller API ? - is the controller needed at all ? The implementation in IPU3 is tested on SGo2. It is not perfect but shows a really better behaviour than default. Right now, the AGC algorithm is part of the RPi one, adapted to the stats and parameters we have in IPU3. Changes in v4: - removed unneeded patch setting exposure and gains - improve documentation of Histogram class - take review comments :-) Changes in v3: - introduce histogram class (for AGC) - add a patch to introduce parameter context saving - changes in AGC to simplify it using part of RPi work - changes in the AWB loop - calculate the grid for the parameters using the BDS size from pipeline handler In v2: - splits AWB and AEC/AGC algorithms. - remove unused Controller - remove unused variables/methods - rename most of the class members Jean-Michel Hautbois (4): ipa: Add a common interface for algorithm objects WIP: ipa: ipu3: Add an histogram class ipa: ipu3: Add support for IPU3 AWB algorithm ipa: ipu3: Add support for IPU3 AEC/AGC algorithm src/ipa/ipu3/ipu3.cpp | 96 +++++++- src/ipa/ipu3/ipu3_agc.cpp | 228 ++++++++++++++++++ src/ipa/ipu3/ipu3_agc.h | 67 ++++++ src/ipa/ipu3/ipu3_awb.cpp | 235 +++++++++++++++++++ src/ipa/ipu3/ipu3_awb.h | 44 ++++ src/ipa/ipu3/meson.build | 8 +- src/ipa/libipa/algorithm.cpp | 39 +++ src/ipa/libipa/algorithm.h | 24 ++ src/ipa/libipa/histogram.cpp | 154 ++++++++++++ src/ipa/libipa/histogram.h | 40 ++++ src/ipa/libipa/meson.build | 6 +- src/ipa/raspberrypi/controller/histogram.hpp | 9 +- 12 files changed, 932 insertions(+), 18 deletions(-) create mode 100644 src/ipa/ipu3/ipu3_agc.cpp create mode 100644 src/ipa/ipu3/ipu3_agc.h create mode 100644 src/ipa/ipu3/ipu3_awb.cpp create mode 100644 src/ipa/ipu3/ipu3_awb.h create mode 100644 src/ipa/libipa/algorithm.cpp create mode 100644 src/ipa/libipa/algorithm.h create mode 100644 src/ipa/libipa/histogram.cpp create mode 100644 src/ipa/libipa/histogram.h