From patchwork Tue Mar 30 05:25:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 11781 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4089CC32F0 for ; Tue, 30 Mar 2021 05:25:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8F9706084F; Tue, 30 Mar 2021 07:25:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="GCd2x8Q7"; dkim-atps=neutral Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 44CFA602D7 for ; Tue, 30 Mar 2021 07:25:29 +0200 (CEST) Received: by mail-pf1-x42a.google.com with SMTP id x126so11325527pfc.13 for ; Mon, 29 Mar 2021 22:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tFk5t1ZHkYsK/fVQT/W/aaDyF5olukG31n8ketoZ8kI=; b=GCd2x8Q7Aru52AtUdjUBFAj9iUROaBkq4BIjORMmguUeFXSjv7w/gNy8wkXlgnuDWW 5VzWOmQqE0Wa/8yJ9ZWsOlvqEnkYXK5FZfvx4NrNYZNwKWF2fUSp83N9E0Z+YyioOiJa B8rFzMvV+ODAArlvh6Eqd8liiJfLIPrVJJQiA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tFk5t1ZHkYsK/fVQT/W/aaDyF5olukG31n8ketoZ8kI=; b=lb2agPV/mMcle9cuuS6gliVLoh98k4PugnRw8neNCrFHMVYUmFSwWBzTtqog5kRLhn 2IlsiepZVas466XqWNkkcwWYzcW8qGtwO1UNXO4vUVDcL9TgNHr45p46uysX7zO2rzAr 3GhTIyldXFr7JXj/Knzrlna3vCVuS73jKgiUrlqoUSiiGIerj7sWtk+OIRV6ph36anG9 GpxsWXxLhAi9dVYBZmCpYCvdNwKkAwVOYkcXnOZBnhK2FuqS36F1ix3HBMIFBnJymExy a+SfpWZH8sHDtne4xED7xXlflFL33TjH6j0AfN3p9/xbBmwtjbpIqVJBnCrW4Xmij0BP 9uAw== X-Gm-Message-State: AOAM5315H1yZHfmQVJlFAu78HHuT/aK9efFFT2vroQSRr34j4JXCfFHi snFRzCSFZkOlPLSOa0xi8x1RIrxVsPS0/g== X-Google-Smtp-Source: ABdhPJwk7RT4GSmc0M04KOvRy2p93vyvUsxevag43rUM/tiVf0TKQUTEdqGF0866VBotM2EE1qbvuA== X-Received: by 2002:a63:c741:: with SMTP id v1mr26394163pgg.207.1617081927256; Mon, 29 Mar 2021 22:25:27 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:c112:2822:484f:486]) by smtp.gmail.com with ESMTPSA id u79sm19726006pfc.207.2021.03.29.22.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 22:25:26 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Mar 2021 14:25:17 +0900 Message-Id: <20210330052521.381550-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/4] Regard crop_rotate_scale_degrees in configuration X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A HAL client requests the demanded rotation by |crop_rotate_scale_degrees| in camera3_stream in configuration. Libcamera ignores it and doesn't handle the rotation request at all. This patch series still don't support it, but add the validation check to the rotation values and deny if a rotation is requested. Change in v2: - Address Jacopo's comments. Change in v3: - Introduce CHROMEOS define macro suggested by Laurent. Hirokazu Honda (4): android: Define CHROMEOS macro if android_platform=cros android: CameraDevice: Validate crop_rotate_scale_degrees in configuration android: CameraDevice: Log rotation variables in camera3_stream android: CameraDevice: Deny non ROTATION_0 stream configuration src/android/camera_device.cpp | 78 +++++++++++++++++++++++++++++++++++ src/android/meson.build | 6 +++ src/libcamera/meson.build | 6 +++ 3 files changed, 90 insertions(+) Reviewed-by: Laurent Pinchart --- 2.31.0.291.g576ba9dcdaf-goog