From patchwork Mon Mar 29 09:15:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 11761 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3C4C2C32EA for ; Mon, 29 Mar 2021 09:16:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A4BFF68784; Mon, 29 Mar 2021 11:16:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="GCHTuj3K"; dkim-atps=neutral Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 171EE6877E for ; Mon, 29 Mar 2021 11:16:00 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id ha17so5708715pjb.2 for ; Mon, 29 Mar 2021 02:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NaLzW1I6NLg1Brc1SEPiEs2f6Tkgnasb+zkTLW23CUI=; b=GCHTuj3KehBhl2DMwxdq/s6LvVRSSgFv3OShBpGPBEkKLooluOOae1C/WKb5GT3oVd 1mhQjkUixlD43A6nfsfH7Qrc/MrTj2OIDqnqUhWwgNQ+DOsMFZZpiGv0SB8Sm1eMAJ2w sC2mmCYFcrtD3loFEVGVfgqlacHkgu6g6vClo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NaLzW1I6NLg1Brc1SEPiEs2f6Tkgnasb+zkTLW23CUI=; b=d9R5PHRybeeaFon+xvNlNeLssEFfKimQBnS+CWX+t8BkGN5H3acl5Uuf2uC+PF03Mm lm/icyXmLvMIU15aCXvHo491E1CTOjP70cxelJOJcVdpUMvm32Mv41cwJj80gR/QAdV4 FMJIWwvvUp1v3yehqMxwswl3kiQqNaGR7mb/ZkK12Yf+gW7OiIukbyi+cdbEji58Tloj fUrhinCFnqQH1C8ZZGdmyesMkoFqbV5yBnXJ4x1Fng0xsXfzVbeolI6N8nD7lQNYW6Vv wHJtCyBlxT1SH0Kg8Mt3yqNzN+PvVwWfV0M4mwZZaFv3YSKE1G3Rara1gETJgYzGFk4Z +2bg== X-Gm-Message-State: AOAM530Gs6a1BnokG5Ln7ndgoehdEkjlXGDzFi3z8lwSSbLSmL3fEFv5 HkEKqUrndAdGbDioyOpTWQP8UiAF3qQv/g== X-Google-Smtp-Source: ABdhPJzt/bA5XHa6PJnItxqesBnRU4LI46ajrH/0zOjax9oP6Yw/XZDALvZER/d+0zTYiDZms9+09w== X-Received: by 2002:a17:902:c1c4:b029:e6:7bc9:71fd with SMTP id c4-20020a170902c1c4b02900e67bc971fdmr26989874plc.5.1617009358150; Mon, 29 Mar 2021 02:15:58 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:1db7:ae60:9288:b906]) by smtp.gmail.com with ESMTPSA id n2sm15818122pga.57.2021.03.29.02.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 02:15:57 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Mar 2021 18:15:49 +0900 Message-Id: <20210329091552.157208-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/3] Add RequestError to Request::Status X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" PipelineHandler doesn't notify a client an error during processing a capture request. This addresses the issue by adding the new enum value to Request::Status, so that each Camera client can know whether the error happens by Request::status(). Change in v2: - Adopt adding RequestError to Request::Status rather than adding an error code to Request - Handle RequestCancelled and RequestError differently in a request completion. Hirokazu Honda (3): libcamera: PipelineHandler: Make queueRequest() void function libcamera: Request: Add RequestError to Status Regard a request error in the request completion Documentation/guides/application-developer.rst | 2 ++ include/libcamera/internal/pipeline_handler.h | 2 +- include/libcamera/request.h | 2 ++ src/cam/capture.cpp | 5 +++++ src/gstreamer/gstlibcamerasrc.cpp | 6 +++++- src/libcamera/camera.cpp | 6 ++++-- src/libcamera/pipeline_handler.cpp | 11 +++++------ src/libcamera/request.cpp | 17 +++++++++++------ src/qcam/main_window.cpp | 4 ++++ src/v4l2/v4l2_camera.cpp | 5 +++++ 10 files changed, 44 insertions(+), 16 deletions(-) --- 2.31.0.291.g576ba9dcdaf-goog