From patchwork Mon Mar 29 00:27:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 11750 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0B78FC32ED for ; Mon, 29 Mar 2021 00:27:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 492C26877D; Mon, 29 Mar 2021 02:27:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="dH/CevMC"; dkim-atps=neutral Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D9C1602D2 for ; Mon, 29 Mar 2021 02:27:24 +0200 (CEST) Received: by mail-pl1-x62e.google.com with SMTP id h8so3573350plt.7 for ; Sun, 28 Mar 2021 17:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n3mzyE+/Rsyt1Tn/kU9yEaKvRTgrWUFEOpVHdPnzUnA=; b=dH/CevMCKOEJkitrNmLYDsGUHuEmhk3iOItCbhJNk2siHUWAIXYxujMBgyMSvNLnAJ lBoR04G3XoA4x9t38x3FddcBatP+c9THyS67nBubKuNJxqJMZaGSg/l61PTPfw7AJORP M67TmhxkWGXAXz0tcKSF8e6JxkWyD9aeLyM3M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n3mzyE+/Rsyt1Tn/kU9yEaKvRTgrWUFEOpVHdPnzUnA=; b=J5XmRVL+wF6DhVj4gz2abyKjoeR5HdPpjk4BQSABPgMZIjyoJ8dhr92nUPI552a1wz QiBrIrR0/nZASp6lUazby1K0IQM1i/DuRlecMxRWXViFZ10x6X/pXLxFM8juKyTRd9aS dtzjUtdcximnIT7CU8hdKYMderRdrihGDx/08umPLMZvq74rDqIJ4gfx5fLr5k5LxRlY OwqteOmri5QvP8XEOkyeuWajjhoozfK/W85VL41HvQEurnBGBDDTmQwPn5/nmrtM9W+5 b0ljTr0+o4bMKP1OCfnw42Ae8rNJIeCXIgvwmaKRw6Jo7GK4/tWKemZ0BFR3K9uwRzZo JB7Q== X-Gm-Message-State: AOAM531USRDUe7eqDRCzi/7V6j/cOPl/p9kpQXIWrDxmPj5nw4x3Fgi7 L7vvt/pJx8mUPL5Z1at5WSLbQydENkidoA== X-Google-Smtp-Source: ABdhPJybWS9wjyX50rt/ksg4M7cDVt3sYLnYk0bllFJJ00gWjzH0IofvC0ODetK8P8XPO5z2ldraIQ== X-Received: by 2002:a17:902:a715:b029:e7:147e:fe90 with SMTP id w21-20020a170902a715b02900e7147efe90mr21402538plq.66.1616977643094; Sun, 28 Mar 2021 17:27:23 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:1db7:ae60:9288:b906]) by smtp.gmail.com with ESMTPSA id j188sm15227209pfd.64.2021.03.28.17.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 17:27:22 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Mar 2021 09:27:12 +0900 Message-Id: <20210329002715.74403-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/3] Handle an request error X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" PipelineHandler doesn't notify a client an error during processing a capture request. This addresses the issue by adding the error value to Request, so that each Camera client can handle a request error in the request completion. Hirokazu Honda (3): libcamera: PipelineHandler: Make queueRequest() void function libcamera: Request: Add an error value Regard a request error in the request completion .../guides/application-developer.rst | 4 ++-- include/libcamera/internal/pipeline_handler.h | 2 +- include/libcamera/request.h | 2 ++ src/android/camera_device.cpp | 6 ++++-- src/cam/capture.cpp | 4 +++- src/gstreamer/gstlibcamerasrc.cpp | 4 ++++ src/libcamera/camera.cpp | 6 ++++-- src/libcamera/pipeline_handler.cpp | 10 ++++----- src/libcamera/request.cpp | 21 ++++++++++++++----- src/qcam/main_window.cpp | 4 +++- src/v4l2/v4l2_camera.cpp | 4 +++- test/camera/buffer_import.cpp | 4 +++- test/camera/capture.cpp | 4 +++- 13 files changed, 53 insertions(+), 22 deletions(-) --- 2.31.0.291.g576ba9dcdaf-goog